Skip to content

build: update liquid to 4.0.4#860

Merged
tsusdere merged 1 commit intogithub:masterfrom
gradybarrett:gradybarrett/liquid-v4-0-4
Feb 1, 2023
Merged

build: update liquid to 4.0.4#860
tsusdere merged 1 commit intogithub:masterfrom
gradybarrett:gradybarrett/liquid-v4-0-4

Conversation

@gradybarrett
Copy link
Copy Markdown

@gradybarrett gradybarrett commented Jan 12, 2023 •
edited
Loading

Ruby 3.2 removed the "tainted" interface, which liquid <=4.0.3
still uses. Liquid 4.0.4 removes references to this interface so that
it works with Ruby 3.2.

Closes #859.

@gradybarrett gradybarrett force-pushed the gradybarrett/liquid-v4-0-4 branch 2 times, most recently from 1a17219 to 899840d Compare January 12, 2023 22:47
@gradybarrett
Copy link
Copy Markdown
Author

gradybarrett commented Jan 12, 2023

@parkr hopefully this PR wasn't presumptuous. 😄

@parkr
Copy link
Copy Markdown
Contributor

parkr commented Jan 13, 2023

Nope! I can't merge this though since I don't work at GitHub anymore. Perhaps @yoannchaudet can help! This patched version fixes compatibility with Ruby 3.2.

@adh1b
Copy link
Copy Markdown

adh1b commented Jan 17, 2023

Would be great to have this merged.

@keithrbennett
Copy link
Copy Markdown

keithrbennett commented Jan 24, 2023

This issue is blocking the use of Ruby 3.2 for Github Pages sites. Could someone with the authority to merge it please take a look at it? It's a simple one-line fix. I can corroborate that tests pass with this change.

mmguero added a commit to mmguero-dev/jekyll-serve that referenced this pull request Jan 24, 2023
@mmguero
revert to Ruby 3.1.x until github/pages-gem#860 is pulled
d1f7a83
@gradybarrett
build: update liquid to 4.0.4
0ab2e26 
Ruby 3.2 removed the "tainted" interface, which liquid
>=4.0.3 still uses. Liquid 4.0.4 removes references to this
interface that it works with Ruby 3.2.

Closes github#859.
@gradybarrett gradybarrett force-pushed the gradybarrett/liquid-v4-0-4 branch from 899840d to 0ab2e26 Compare January 25, 2023 03:17
@gradybarrett
Copy link
Copy Markdown
Author

gradybarrett commented Jan 25, 2023

Updated the branch and fixed my gpg config.

@vhxs
Copy link
Copy Markdown

vhxs commented Jan 25, 2023

+1 please merge this in, I've had to explicitly point my blog towards this forked repo

@JonathanCopeland
Copy link
Copy Markdown

JonathanCopeland commented Jan 26, 2023

Can confirm this is still a problem, I'm receiving:
Liquid Exception: undefined method `tainted?' for ...

Any ETA on when this will be merged?

@yoannchaudet
Copy link
Copy Markdown
Contributor

yoannchaudet commented Jan 26, 2023

Surfacing that to the team, we will look at it shortly and make a round of update.

@parkr
Copy link
Copy Markdown
Contributor

parkr commented Jan 27, 2023

@yoannchaudet I'm making a bug patch release of Jekyll soon that allows y'all to also upgrade i18n and tzinfo, if you want to bundle this patch release into your round of updates: jekyll/jekyll#9282

@surelynottrue
Copy link
Copy Markdown

surelynottrue commented Jan 30, 2023

Is there any solution in place for this? This error is not allowing me to push any changes to my Jekyll website :)

@JonathanCopeland
Copy link
Copy Markdown

JonathanCopeland commented Jan 30, 2023

Same

@parkr
Copy link
Copy Markdown
Contributor

parkr commented Jan 31, 2023

Hopefully you upgrade the Ruby used by your Jekyll site independently from other apps you maintain! I personally always run CI with any ruby or gem updates before merging. Then I can still push updates to my site while I wait for the update to be compatible. I recommend rbenv for maintaining several different Ruby versions on the same system.

@tsusdere tsusdere merged commit b0f457c into github:master Feb 1, 2023
@gradybarrett gradybarrett deleted the gradybarrett/liquid-v4-0-4 branch February 2, 2023 00:56
@JonathanCopeland
Copy link
Copy Markdown

JonathanCopeland commented Feb 2, 2023

Hey everyone, I'm probably missing something, but after running bundle update github-pages I'm still getting the tainted error. Is there anything else that I need to do to serve my site locally?

@yoannchaudet
Copy link
Copy Markdown
Contributor

yoannchaudet commented Feb 2, 2023 •
edited
Loading

The gem has not been fully propagated in the systems. It is being updated today. https://pages.github.com/versions/ will report it as soon as it's there.

@parkr parkr mentioned this pull request Feb 2, 2023
Closed
@yoannchaudet
Copy link
Copy Markdown
Contributor

yoannchaudet commented Feb 3, 2023

We should be good now: https://pages.github.com/versions. Still updating our legacy build infra but build on Actions are already current.

@parkr
Copy link
Copy Markdown
Contributor

parkr commented Feb 3, 2023

Thank you so much, @yoannchaudet!

@JonathanCopeland
Copy link
Copy Markdown

JonathanCopeland commented Feb 5, 2023

Working 100%. Thank you very much @yoannchaudet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsusdere tsusdere tsusdere approved these changes

+1 more reviewer

@parkr parkr parkr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: undefined method tainted? when using Ruby v3.2.0

10 participants

@gradybarrett @parkr @adh1b @keithrbennett @vhxs @JonathanCopeland @yoannchaudet @surelynottrue @decherneyge @tsusdere