This repository was archived by the owner on Jul 8, 2024. It is now read-only.
Merged
Conversation
During the initial work on projection and while we had the VFS API in this library, I envisioned a need for the VFS code to call an internal, common function to make a directory (either projected, or normal). That need never materialized, so we can eliminate this function entirely.
Without any shared code between the primary library and a VFS API, there's no need for an internal header file at the moment, so we can eliminate it.
As there is no compelling reason not to allow libprojfs callers to specify the permission mode bits of a projected directory, we can support this in our API, and defer to our callers (VFSForGit in particular) to supply the directory permissions they expect or require.
allow arbitrary permission modes on projected dirs
kivikakk
approved these changes
Mar 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without any code to share with the VFS API, we can eliminate the
projfs_i.hfunction and we also don't need the_projfs_make_dir()function any more.