This repository was archived by the owner on Jul 8, 2024. It is now read-only.
allow arbitrary permission modes on projected dirs#55
Merged
kivikakk merged 1 commit intoremove-vfsapi-internal-headerfrom Mar 4, 2019
Merged
allow arbitrary permission modes on projected dirs#55kivikakk merged 1 commit intoremove-vfsapi-internal-headerfrom
kivikakk merged 1 commit intoremove-vfsapi-internal-headerfrom
Conversation
As there is no compelling reason not to allow libprojfs callers to specify the permission mode bits of a projected directory, we can support this in our API, and defer to our callers (VFSForGit in particular) to supply the directory permissions they expect or require.
This was referenced Mar 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As there is no compelling reason not to allow libprojfs callers to specify the permission mode bits of a projected directory, we can support this in our API, and defer to our callers (VFSForGit in particular) to supply the directory permissions they expect or require.
Note that this requires a change in the VFSForGit
ProjFS.Linuxcode as well.