Add ignorer to .env.test variable in NodeJS#2908
Merged
shiftkey merged 1 commit intogithub:masterfrom Dec 18, 2018
Merged
Conversation
Member
|
@lmedson thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change:
while working on my project, I realized that I always needed to add an ignore in the .env variable of tests, where I call .env.test, and I thought that many other people using this pattern go through the same thing, so I decided to try to sub.
Links to documentation supporting these rule changes:
I dont have a specific documentation link talking about having to use this pattern, but it's almost a convention, separating .env from tests by .env.test
If this is a new template:
None