Conversation
mutle
approved these changes
Sep 20, 2016
Merged
rubiojr
added a commit
that referenced
this pull request
Sep 20, 2016
Bug fixes and required tooling to detect SSH host keys that should be blacklisted, see https://enterprise.github.com/releases/2.7.4/notes * Cluster: fix offline cluster node detection #253 * Detect leaked ssh keys in backup snapshots #250
rubiojr
added a commit
that referenced
this pull request
Sep 20, 2016
Bug fixes and required tooling to detect SSH host keys that should be blacklisted, see https://enterprise.github.com/releases/2.7.4/notes * Cluster: fix offline cluster node detection #250 * Detect leaked ssh keys in backup snapshots #253
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ghe_cluster_online_nodes function currently fails to exclude offline nodes. As a consquence, if a cluster node is marked as offline, the backup utilities still attempts to backup from this node, and the backup fails as a result.
This is because of a syntax error in the xargs command:
The correct syntax is:
/cc @github/backup-utils for review