enforcing style rules#32
Merged
Merged
Conversation
aaronpowell
commented
Jul 3, 2025
Contributor
- Fixing line endings and removing dead code
- Missing descriptions due to line endings
- Enforcing that the line endings should be LF
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes on LF line endings, removes dead code related to chat modes generation, and adds CI enforcement.
- Removed outdated logic for regenerating the custom chat modes section in
update-readme.js. - Added a Development Configuration section in
README.mdto document LF enforcement. - Introduced a GitHub Actions workflow to block CRLF line endings in markdown files.
Reviewed Changes
Copilot reviewed 3 out of 12 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| update-readme.js | Stripped out obsolete chat modes list regeneration code |
| README.md | Added development config section explaining line endings policy |
| .github/workflows/check-line-endings.yml | New workflow to detect and fail on CRLF in markdown files |
Files not reviewed (5)
- .editorconfig: Language not supported
- .gitattributes: Language not supported
- .vscode/extensions.json: Language not supported
- .vscode/settings.json: Language not supported
- scripts/fix-line-endings.sh: Language not supported
Comments suppressed due to low confidence (2)
update-readme.js:355
- The removal of the entire branch handling chat modes insertion appears to drop all logic for updating the README with custom chat modes. If this is intentional, please ensure that you update or remove any related references elsewhere, and add tests to cover the new behavior; otherwise, restore the necessary parts to maintain functionality.
return `${TEMPLATES.chatmodesSection}\n\n${chatmodesContent}\n${TEMPLATES.chatmodesUsage}`;
.github/workflows/check-line-endings.yml:17
- [nitpick] To make the check more robust, consider using
git grep -I --files-with-matches '\r' -- '*.md'or pipingfindintoxargs grep, which handles filenames with spaces and scales better on large repositories.
! grep -l $'\r' $(find . -name "*.md")
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…some-copilot into enforcing-style-rules
16 tasks
Copilot AI
added a commit
that referenced
this pull request
May 19, 2026
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
aaronpowell
added a commit
that referenced
this pull request
May 19, 2026
* chore: publish from staged * Initial plan * Fix double-unescaping in decodeEntities (alert #32) Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.