Skip to content

Use encodeXmlEntities for formatCode attributes#955

Merged
gitbrent merged 1 commit intomasterfrom
unknown repository
Nov 28, 2021
Merged

Use encodeXmlEntities for formatCode attributes#955
gitbrent merged 1 commit intomasterfrom
unknown repository

Conversation

@dimfeld
Copy link

@dimfeld dimfeld commented May 20, 2021

The format codes generated by Powerpoint often contain quotes, and so this ensures that they generate valid XML.

e.g. the default currency formatter used by Powerpoint is _(" $"* #,##0.00_);_(" $"* \(#,##0.00\);_(" $"* " -"??_);_(@_)

@gitbrent gitbrent self-assigned this Aug 29, 2021
@gitbrent gitbrent added this to the 3.9.0 milestone Oct 1, 2021
@gitbrent gitbrent mentioned this pull request Nov 28, 2021
@gitbrent gitbrent merged commit a803069 into gitbrent:master Nov 28, 2021
@gitbrent
Copy link
Owner

Thanks @dimfeld !

gitbrent added a commit that referenced this pull request Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants