Skip to content

Add Alt Text to charts#848

Closed
yorch wants to merge 3 commits intogitbrent:masterfrom
yorch:chart-alt-text
Closed

Add Alt Text to charts#848
yorch wants to merge 3 commits intogitbrent:masterfrom
yorch:chart-alt-text

Conversation

@yorch
Copy link

@yorch yorch commented Sep 24, 2020 •
edited
Loading

Alt text for charts is not currently populated, so it's not fully accesible. Adding a descr property to the charts translates to Alt Text box in PPT.

@gitbrent gitbrent added this to the 3.5.0 milestone Dec 26, 2020
@gitbrent gitbrent self-assigned this Dec 26, 2020
@gitbrent gitbrent modified the milestones: 3.5.0, 3.6.0 Feb 26, 2021
gitbrent added a commit that referenced this pull request Apr 27, 2021
@gitbrent
Add alt text to charts (Pull #848)
9f38c29
@gitbrent
Copy link
Owner

gitbrent commented Apr 27, 2021

Thanks @yorch

Screen Shot 2021-04-26 at 22 18 33

Screen Shot 2021-04-26 at 22 17 56

@gitbrent gitbrent closed this Apr 27, 2021
@yorch
Copy link
Author

yorch commented Apr 28, 2021

@gitbrent awesome, thank you!

@yorch
Copy link
Author

yorch commented May 4, 2021

@gitbrent just realized that the commit with the change does not include altText support for images as I included in this PR (https://github.com/gitbrent/PptxGenJS/pull/848/files#diff-2e10387a0f5301958ef328618c21a1df1de827655aec5abbe99bf0ba59631f5dR1785-R1789). Is this is something you can include?
Thanks

gitbrent added a commit that referenced this pull request May 9, 2021
@gitbrent
added altText to images (Pull #848)
adf755b
@gitbrent
Copy link
Owner

gitbrent commented May 9, 2021

@yorch - quite correct. I meant to modify the current alt text on Images, but i got distracted. It's always had an alt text value of the image path, so i've set to where it uses altText if provided, then the path if none.

Screen Shot 2021-05-09 at 16 16 29

@yorch
Copy link
Author

yorch commented May 13, 2021

@gitbrent great, thanks so much! looking forward for a new version :D

@yorch
Copy link
Author

yorch commented Jul 21, 2021

@gitbrent just saw a new version was released, thanks, been waiting for this new release for a while. Unfortunately, the TS definition for addImage is not correct, it's missing the altText option.

It's here:

PptxGenJS/src/core-interfaces.ts

Line 422 in 9e6aab8

export interface ImageProps extends PositionProps, DataOrPathProps {

But it's not here:

PptxGenJS/types/index.d.ts

Line 1241 in 9e6aab8

export interface ImageProps extends PositionProps, DataOrPathProps {

Thanks again

gitbrent added a commit that referenced this pull request Jul 22, 2021
@gitbrent
Added new altText property (Issue #848)
650d402
gitbrent added a commit that referenced this pull request Jul 22, 2021
@gitbrent
Added missing altText prop to ImageProps (Issue #848)
56184ed
@gitbrent
Copy link
Owner

gitbrent commented Jul 22, 2021

@yorch Oops! Thanks for letting me know. v3.7.1 has been released with altText included in the defs file.

@yorch
Copy link
Author

yorch commented Jul 22, 2021

@gitbrent thanks! much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gitbrent gitbrent

Labels

enhancement-chart

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@yorch @gitbrent