solution for issue #625#1133
Merged
gitbrent merged 3 commits intogitbrent:masterfrom Feb 8, 2023
mikemeerschaert:add-reference-to-new-slides-created-by-table-auto-paging
Merged
solution for issue #625#1133gitbrent merged 3 commits intogitbrent:masterfrom mikemeerschaert:add-reference-to-new-slides-created-by-table-auto-paging
gitbrent merged 3 commits intogitbrent:masterfrom
mikemeerschaert:add-reference-to-new-slides-created-by-table-auto-paging
Conversation
|
this last version is v3.10.0,no have |
Owner
|
Thanks @mikemeerschaert Patches need to be against the code src/*.ts files. Files under See other recent pull requests for examples. |
…g' of https://github.com/mikemeerschaert/PptxGenJS into add-reference-to-new-slides-created-by-table-auto-paging
Contributor
Author
|
Sorry about that @gitbrent, I removed the auto-generated files. |
Owner
|
Great work, thanks @mikemeerschaert ! |
Contributor
Author
|
@xingkoo in case you didn't see, this was released yesterday with v3.12.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #625 by adding a reference to the newly created slides created by an auto-paged table.
Example usage would look like this:
I also updated
EX-3: "Master Page with Auto-Paging"to demonstrate / test the functionality, and created a new master slide that's a copy ofMASTER_PLAINbut with a placeholder option in the slide footer.I'm submitting this because I urgently need this feature to work, the workarounds listed on #625 don't work for my specific use case without a major re-write of a large project, so I'm hoping to get the ball rolling on this. I totally understand if you don't want another property added to
slide, so if there is a better solution I'm happy to help implement it to get it done quicker.Thanks for your consideration!