Support bubble 3D chart type#1108
Merged
gitbrent merged 1 commit intogitbrent:masterfrom May 15, 2022
Merged
Conversation
Owner
|
Thanks @mathbruyen - great work!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support bubble chart with a 3D appearance for bubbles instead of a solid display.
Implementation is done as a new chart type as Powerpoint UI defines it as a different type and bar 3D is defined as its own type as well. I'm not sure it is the best way, especially as even though Powerpoint UI treats it as a different chart type, in the XML it is a bubble chart with an option set to
1. An alternative could be with a property (likebubble3d: booleanorbubbleAppearence = 'solid' | '3d') but there is no existing type for bubble chart specific options.If you prefer that setting to be done in any way feel free to tell and I will update the PR accordingly.