I added central caching of the *netrc.Netrc object in Config. Also added a platform specific netrcBasename var that's set to .netrc everywhere except windows, which uses _netrc.

This looks good, but script/integration is hanging locally after the last test. The "master" and even the latest "cred-fixes" branches both work flawlessly for me.

I'm going to hold it back from v1.1 until that can be checked out, and the netrc feature itself can be tested a bit more. Should be a shoe-in for v1.2 though.

It hangs because netrcBasename is blank because go on osx won't build the file config_linux.go, even if the build tag tells it to. You have to name it something that isn't a platform name:

Naming a file dns_windows.go will cause it to be included only when building the package for Windows; similarly, math_386.s will be included only when building the package for 32-bit x86.

I think I usually see them as _nix or _unix.

Doh, good catch.

On Wed, Nov 18, 2015 at 11:47 AM, Scott Barron notifications@github.com
wrote:

It hangs because netrcBasename is blank because go on osx won't build the
file config_linux.go, even if the build tag tells it to. You have to name
it something that isn't a platform name:

Naming a file dns_windows.go will cause it to be included only when building the package for Windows; similarly, math_386.s will be included only when building the package for 32-bit x86.

I think I usually see them as _nix or _unix.

—
Reply to this email directly or view it on GitHub
#715 (comment).

Rick Olson

I pushed a change that renames the file, but also changes the way the variable is set. Instead of a var + init() in the build flagged files, the build flagged files should define the variable. With this pattern, the build would have failed immediately because nothing defined netrcBasename.