Conversation
Call 'go generate ./commands' to create string entries from .ronns which the cobra command can then use (added to the build scripts)
* Strips leader and footer which were just clutter * Reformats headers & removes unnecessary ones * Indents paragraphs following bullets Still TODO: reformat links
|
Opps! sorry for duplicated PR ;-( |
|
First, no worries about duplicate PRs. That's all good :) It seems odd that those commits from Sinbad are showing up again. Is your master up to date with the root's master? I want to simplify the output. The brackets make the filename difficult to see, especially when there are multiple entries: $ git lfs ls-files -l
50eb175bbfde63504add621427a6a98910e89697 ==> [ gif/droidtocat.gif,gif/dupe.gif ]
ba2f35f8b0ec51d85ffcc973e5297e22682bb2cd ==> [ png/render.png ]How about something like this? The output is easier to read. We can also include an indicator showing LFS objects ( $ git lfs ls-files -l
50eb175bbfde63504add621427a6a98910e89697 * gif/droidtocat.gif
50eb175bbfde63504add621427a6a98910e89697 * gif/dupe.gif
ba2f35f8b0ec51d85ffcc973e5297e22682bb2cd - png/render.pngEDIT: One bonus is this output is easier to chop up: $ git lfs ls-files | cut -f 3 -d " "
gif/droidtocat.gif
gif/dupe.gif
png/render.png
$ git lfs ls-files | cut -f 1 -d " "
50eb175
50eb175
ba2f35fAlso, I'm thinking we can drop the call to |
|
I made a new PR with your commits: #681 I don't like this PR because Sinbad's commits are rebased on top of it. Compare: Ideally, pull requests should not be doing that. You should never commit to your master branch in the fork. When you want to make a PR, merge the original repo's master branch into your fork's. If your master branch is unmodified, then this should be a fast forward. Then you can cut a feature branch with your changes. Thanks again for tackling this! With your changes, this should be a much better diagnostic tool for end users. |
|
Thank you for all your advice. @technoweenie for you ask on previous PR, I think |
from #674 I just change to show OIDs and filenames.