Skip to content

change ls-files to list OID(s)#680

Closed
aorjoa wants to merge 8 commits intogit-lfs:masterfrom
aorjoa:dev
Closed

change ls-files to list OID(s)#680
aorjoa wants to merge 8 commits intogit-lfs:masterfrom
aorjoa:dev

Conversation

@aorjoa
Copy link
Contributor

@aorjoa aorjoa commented Sep 25, 2015

from #674 I just change to show OIDs and filenames.

sinbad and others added 8 commits September 19, 2015 14:03
Call 'go generate ./commands' to create string entries from .ronns which
the cobra command can then use (added to the build scripts)
* Strips leader and footer which were just clutter
* Reformats headers & removes unnecessary ones
* Indents paragraphs following bullets

Still TODO: reformat links
@aorjoa
Copy link
Contributor Author

aorjoa commented Sep 25, 2015

Opps! sorry for duplicated PR ;-(

@technoweenie
Copy link
Contributor

First, no worries about duplicate PRs. That's all good :) It seems odd that those commits from Sinbad are showing up again. Is your master up to date with the root's master?

I want to simplify the output. The brackets make the filename difficult to see, especially when there are multiple entries:

$ git lfs ls-files -l
50eb175bbfde63504add621427a6a98910e89697 ==> [ gif/droidtocat.gif,gif/dupe.gif ]
ba2f35f8b0ec51d85ffcc973e5297e22682bb2cd ==> [ png/render.png ]

How about something like this? The output is easier to read. We can also include an indicator showing LFS objects (*) vs LFS pointers (-).

$ git lfs ls-files -l
50eb175bbfde63504add621427a6a98910e89697 * gif/droidtocat.gif
50eb175bbfde63504add621427a6a98910e89697 * gif/dupe.gif
ba2f35f8b0ec51d85ffcc973e5297e22682bb2cd - png/render.png

EDIT: One bonus is this output is easier to chop up:

$ git lfs ls-files | cut -f 3 -d " " 
gif/droidtocat.gif
gif/dupe.gif
png/render.png

$ git lfs ls-files | cut -f 1 -d " "
50eb175
50eb175
ba2f35f

Also, I'm thinking we can drop the call to ScanRefs and just rely on ScanTree. That seems like what users would expect. What do you think?

@technoweenie technoweenie mentioned this pull request Sep 25, 2015
@technoweenie
Copy link
Contributor

I made a new PR with your commits: #681

I don't like this PR because Sinbad's commits are rebased on top of it. Compare:

Ideally, pull requests should not be doing that. You should never commit to your master branch in the fork. When you want to make a PR, merge the original repo's master branch into your fork's. If your master branch is unmodified, then this should be a fast forward. Then you can cut a feature branch with your changes.

Thanks again for tackling this! With your changes, this should be a much better diagnostic tool for end users.

@aorjoa
Copy link
Contributor Author

aorjoa commented Sep 26, 2015

Thank you for all your advice. @technoweenie for you ask on previous PR, I think * and - look good and I think we can use scanTree instead (but I don't know impact in deep).

@technoweenie
Copy link
Contributor

@aorjoa Thanks for your help here. I merged these commits in #681, plus a few other changes.

@aorjoa aorjoa deleted the dev branch October 8, 2015 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants