Skip to content

support git lfs ls-files show duplicate files#674

Closed
aorjoa wants to merge 0 commit intogit-lfs:masterfrom
aorjoa:master
Closed

support git lfs ls-files show duplicate files#674
aorjoa wants to merge 0 commit intogit-lfs:masterfrom
aorjoa:master

Conversation

@aorjoa
Copy link
Contributor

@aorjoa aorjoa commented Sep 19, 2015

according #307 report $git lfs ls-files not list duplicate, i think this feature importance to me and then i have hack some code please review my code and suggest me :)

@technoweenie
Copy link
Contributor

Thanks for the patch :) What do you think about just listing the OIDs and filenames? I don't know if we need to see the "duplicate of other-file.ext" messages. But seeing multiple files with the same OID should tip off the fact that they're dupes.

@technoweenie
Copy link
Contributor

I've been thinking about this more. I think it's time to rewrite fsck. For one, it can take advantage of lfs.ScanTree(), instead of lfs.ScanRefs(). I think that it should always do the following:

  1. Ensure every file in .git/lfs/objects matches its own OID
  2. Ensure every file in the working directory that matches the configured include/exclude settings

Maybe even add include/exclude flags to fsck, like fetch takes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants