Skip to content

Add RISC-V support#5438

Merged
bk2204 merged 2 commits intogit-lfs:mainfrom
AaronDewes:main
Aug 1, 2023
Merged

Add RISC-V support#5438
bk2204 merged 2 commits intogit-lfs:mainfrom
AaronDewes:main

Conversation

@AaronDewes
Copy link
Contributor

@AaronDewes AaronDewes commented Jul 24, 2023

This adds support for the RISC-V architecture.

@bk2204
Copy link
Member

bk2204 commented Jul 24, 2023

Thanks for the patch, and welcome to Git LFS! I think we'll also need a patch to script/upload in categorize_arch, which should call it 64-bit RISC-V.

If you want to test that script, you can do so against your remote by adding a personal access token into your ~/.netrc, updating the REPO field in the top of the script to your personal fork, creating an annotated tag of your local version (call it TAG), and running script/upload --skip-verify TAG. That should create a draft release in your version for the tag that you can use to verify that the name appears as it should.

@AaronDewes AaronDewes marked this pull request as ready for review July 25, 2023 08:49
@AaronDewes AaronDewes requested a review from a team as a code owner July 25, 2023 08:49
@AaronDewes
Copy link
Contributor Author

AaronDewes commented Jul 25, 2023

Thanks! I tested this and it works.

bk2204
bk2204 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@bk2204 bk2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

Just to set expectations, this won't be included in v3.4.0, since we've already cut the release, but this should be included in v3.5.0. We'll merge it once v3.4.0 is out.

@AaronDewes
Copy link
Contributor Author

AaronDewes commented Jul 25, 2023

Thanks for letting me know! I saw the PR and noticed the release was scheduled for tomorrow, so I didn't expect this to make it into the release, which is unfortunate for me, but I guess I'll have to be patient and I can already build from source for now.

@bk2204 bk2204 merged commit c694e5c into git-lfs:main Aug 1, 2023
chrisd8088 added a commit to chrisd8088/git-lfs that referenced this pull request Nov 23, 2024
@chrisd8088
docs/howto/release-git-lfs.md: add RISC-V 64 asset
5c9e5ed 
In PR git-lfs#5438 we added support in our Makefile and scripts to build and
upload a version of our Linux release assets for the RISC-V 64 platform.

As the documentation of our release process includes a list of the
Linux assets we build, we now add an entry for the RISC-V 64 platform
so as to match the assets listed in our public release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bk2204 bk2204 bk2204 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AaronDewes @bk2204