standalone: print an error if the destination isn't a Git repository#5283
Merged
bk2204 merged 2 commits intogit-lfs:mainfrom Feb 14, 2023
Merged
standalone: print an error if the destination isn't a Git repository#5283bk2204 merged 2 commits intogit-lfs:mainfrom
bk2204 merged 2 commits intogit-lfs:mainfrom
Conversation
When the handler setup fails, we just exit right now, instead of sending an error message. That leads to less than helpful behaviour if the destination repository isn't a valid Git repository for whatever reason. To improve this, let's make sure that we return an error message at setup if something fails so that the user in turn gets an error message.
If `git rev-parse --git-dir` fails, Git doesn't think that the destination is a valid repository for whatever reason. One of the most common reasons for that is that the repository is owned by another user. In such a case, we want to show the error message from Git, since we really have no other indication that this is the case. It could be just that the destination isn't a repository at all. Regardless, the error message would be useful to the user to determine the problem, so let's return it if standard error isn't empty.
7497d7e to
a1e8632
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
git rev-parse --git-dirfails, Git doesn't think that the destination is a valid repository for whatever reason. One of the most common reasons for that is that the repository is owned by another user.In such a case, we want to show the error message from Git, since we really have no other indication that this is the case. It could be just that the destination isn't a repository at all. Regardless, the error message would be useful to the user to determine the problem, so let's return it if standard error isn't empty.
We also have an initial commit that sets up the error message processing.
Fixes #5081