Skip to content

Check for github action updates monthly#5228

Merged
chrisd8088 merged 2 commits intogit-lfs:mainfrom
jlosito:dbot
Jan 4, 2023
Merged

Check for github action updates monthly#5228
chrisd8088 merged 2 commits intogit-lfs:mainfrom
jlosito:dbot

Conversation

@jlosito
Copy link
Contributor

@jlosito jlosito commented Dec 19, 2022

This will use dependabot to check any github action which this project uses for updates in order to keep it up-to-date.

https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot

@jlosito jlosito requested a review from a team as a code owner December 19, 2022 01:57
@chrisd8088
Copy link
Member

chrisd8088 commented Dec 19, 2022

Hey, thanks for the PR and welcome to Git LFS!

This seems like a good idea, in general, but I am concerned we may see a number of issues reported about our use of the actions/setup-ruby@v1 action rather than the ruby/setup-ruby@v1 one. However, as I reported in ruby/setup-ruby#293, the latter changes PATH in such a way as to cause the system default Git LFS to run instead of our newly-built git-lfs.exe binary which we want to test. Fixing that did not seem trivial, so for the moment we are sticking with the older action, although it's deprecated.

@chrisd8088
Copy link
Member

chrisd8088 commented Dec 19, 2022 •
edited
Loading

Just as a note for the future, if we adopt this change, we should also make a parallel change to the Actions workflows in git-lfs/gitobj and git-lfs/wildmatch.

@jlosito
Copy link
Contributor Author

jlosito commented Dec 19, 2022

@chrisd8088 should I add an ignore section for the action which you are referring to so that the bot leaves that action alone?

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#ignore

@chrisd8088
Copy link
Member

chrisd8088 commented Dec 19, 2022

should I add an ignore section for the action which you are referring to so that the bot leaves that action alone?

Perhaps, but let me see if I can make any progress on the issue for a bit first. It would also be nice to get that resolved somehow.

@chrisd8088
Copy link
Member

chrisd8088 commented Dec 22, 2022

I've opened #5236 which upgrades our use of actions/setup-ruby@v1 to ruby/setup-ruby@v1. The core team is mostly going to be on vacation for a while, so it might take a while to be approved to merge. However, once that's done (and maybe a few other stale Actions are updated too, in other PRs), I think this should be good to go.

Thanks again for the PR and for your patience!

chrisd8088 added a commit to chrisd8088/gitobj that referenced this pull request Dec 24, 2022
@chrisd8088
.github/dependabot.yml: add monthly Actions checks
d2762b4 
We schedule monthly checks by the GitHub Dependabot service of
our CI workflow to ensure we are using the latest available versions
of all GitHub Actions steps.

h/t jlosito for the suggestion in git-lfs/git-lfs#5228
chrisd8088 added a commit to chrisd8088/gitobj that referenced this pull request Dec 24, 2022
@chrisd8088
.github/dependabot.yml: add monthly Actions checks
2b70a3e 
We schedule monthly checks by the GitHub Dependabot service of
our CI workflow to ensure we are using the latest available versions
of all GitHub Actions steps.

h/t jlosito for the suggestion in git-lfs/git-lfs#5228
@chrisd8088 chrisd8088 mentioned this pull request Dec 24, 2022
Merged
chrisd8088 added a commit to chrisd8088/wildmatch that referenced this pull request Dec 24, 2022
@chrisd8088
.github/dependabot.yml: add monthly Actions checks
75115cf 
We schedule monthly checks by the GitHub Dependabot service of
our CI workflow to ensure we are using the latest available versions
of all GitHub Actions steps.

h/t jlosito for the suggestion in git-lfs/git-lfs#5228
This was referenced Dec 24, 2022
Merged
Merged
Merged
@chrisd8088
Copy link
Member

chrisd8088 commented Dec 30, 2022

I've also added #5243 which should upgrade all the other Actions steps to the latest available versions. It's currently built on top of #5236 so I'll wait to merge that one first before taking the new one out of draft mode.

chrisd8088
chrisd8088 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@chrisd8088 chrisd8088 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I think we've now updated all our workflow steps in advance, so I'll merge this once CI is green. Thanks again!

@chrisd8088 chrisd8088 merged commit e589788 into git-lfs:main Jan 4, 2023
@jlosito jlosito deleted the dbot branch January 12, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisd8088 chrisd8088 chrisd8088 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jlosito @chrisd8088 @Melaih23