remove unused Pipe[Media]Command() functions#4942
Merged
chrisd8088 merged 1 commit intogit-lfs:mainfrom Apr 14, 2022
Merged
Conversation
The PipeCommand() function was added in commit 8b18f62 in the initial prototype work on this project in order to run the original bin/git-media-{clean,smudge} programs. The PipeMediaCommand() function was then added in commit 9cff651 to abstract the addition of the "bin/" prefix to the program names into a single function. As of commit 24b1939 in 2014, however, which was also part of that early prototyping phase, the bin/git-media-{clean,smudge} programs were replaced with "git media clean|smudge", precursors of our contemporary "git lfs clean|smudge" programs, and the Pipe[Media]Command() functions stopped being used to communicate with the programs. No other users of these functions have appeared since that time, so we just remove them now; they can always be recovered from our commit history if pipe wrapper functions are needed again in the future.
bk2204
approved these changes
Apr 14, 2022
Member
bk2204
left a comment
There was a problem hiding this comment.
I'm always a fan of deleting unneeded code.
bk2204
pushed a commit
that referenced
this pull request
Apr 19, 2022
remove unused `Pipe[Media]Command()` functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PipeCommand()function was added in commit 8b18f62 in the initial prototype work on this project in order to run the originalbin/git-media-{clean,smudge} programs. ThePipeMediaCommand()function was then added in commit 9cff651 to abstract the addition of thebin/prefix to the program names into a single function.As of commit 24b1939 in 2014, however, which was also part of that early prototyping phase, the
bin/git-media-{clean,smudge}programs were replaced withgit media clean|smudge, precursors of our contemporarygit lfs clean|smudgeprograms, and thePipe[Media]Command()functions stopped being used to communicate with the programs.No other users of these functions have appeared since that time, so we just remove them now; they can always be recovered from our commit history if pipe wrapper functions are needed again in the future.