Conversation
Disabled tests in rpm build for now... Auto parse lfs/lfs.go to get Version number and update SPEC automatically Fixed git not getting installed if not already installed on CentOS 5 Made rpm build script work from any directory Fixed some indentation
Updated INSTALL.md Added a numch of small changes so build-centos doesn't fail after running build_rpms, and vice versa. Made compiling rpm with nodeps easier
rpm/INSTALL.md
Outdated
|
I found some issues in Two of the issues are in the current revision of |
There was a problem hiding this comment.
a valid used.
"user" ?
|
Honestly I'll need automated centos builds before I'll feel super comfortable merging these. If you can confirm my used/user suspicion above, I can merge and make that tiny tweak. The indentation question isn't important. I can undo the indentation, but it looks like it was done on purpose. I'm more curious about it than anything. EDIT: I don't want to imply that I want you to setup automated centos builds. I want to set aside some time to mess with Digital Ocean to get automated centos/debian builds. I also really appreciate your help on this project :) |
Backport #428 for v0.5.x: Centos fixup
In commit e2f770c of PR git-lfs#428 the rpm/build_rpms.bsh script was updated to run the rpmbuild command with the --nodeps option when the NODEPS environment variable was defined and set non-zero. However, in commit 88430de of PR git-lfs#654 the script was revised to always pass the --nodeps option to the rpmbuild command, so the NODEPS environment variable no longer had any effect, and so We can therefore remove our handling of this variable.
In commit e2f770c of PR git-lfs#428 the rpm/build_rpms.bsh script was updated to run the rpmbuild command with the --nodeps option when the NODEPS environment variable was defined and set non-zero. However, in commit 88430de of PR git-lfs#654 the script was revised to always pass the --nodeps option to the rpmbuild command, so the NODEPS environment variable no longer had any effect, and so We can therefore remove our handling of this variable.
Added a bunch of minor fixes for building in CentOS