Merged
Conversation
Introduced in commit daebd31 and PR github/git-lfs#31, but never used.
See “Hacking with Andrew and Brad: tip.golang.org” https://youtu.be/1rZ-JorHJEY?t=7m57s (Andrew Gerrand and Brad Fitzpatrick are part of the Go core team.)
Picks up an idea by @technoweenie: #380 (comment)
Contributor
Author
There was a problem hiding this comment.
Since this is already caching the bool check, we can use os.Getenv() here, and not worry about caching it in the gitConfig map. Perhaps a micro optimization that doesn't really matter.
Also, should bool checks actually look at the value, instead of seeing if the string is non empty? Common accepted values could be 1, true, or on, while values like 0, false, and off could still be false.
Contributor
Author
|
I'm going to merge this. The git config bool checks can be looked at in another PR if it's important enough. |
michael-k
added a commit
to michael-k/git-lfs
that referenced
this pull request
Jun 16, 2015
Regards git-lfs#387, git-lfs#399 Closes git-lfs#401
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges latest master into #387.