Skip to content

Do not defer close in loop#384

Merged
rubyist merged 1 commit intogit-lfs:masterfrom
michael-k:defer-in-loop
Jun 15, 2015
Merged

Do not defer close in loop#384
rubyist merged 1 commit intogit-lfs:masterfrom
michael-k:defer-in-loop

Conversation

@michael-k
Copy link
Contributor

See #378 (comment):

There are a couple problems that are causing the tests to deadlock.

The first one is easy, some of the download tests are doing a defer reader.Close() in a loop when it should just be closing them immediately, causing the deadlock:

@michael-k michael-k mentioned this pull request Jun 15, 2015
rubyist added a commit that referenced this pull request Jun 15, 2015
@rubyist rubyist merged commit 62352a1 into git-lfs:master Jun 15, 2015
@rubyist
Copy link
Contributor

rubyist commented Jun 15, 2015

Thanks for pulling this out 👍

@michael-k michael-k deleted the defer-in-loop branch June 15, 2015 21:40
@technoweenie technoweenie mentioned this pull request Jun 16, 2015
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants