Skip to content

Remove unnecessary exec the process by filter wrapper#377

Merged
technoweenie merged 1 commit intogit-lfs:masterfrom
bozaro:more-fast-filter
Jun 10, 2015
Merged

Remove unnecessary exec the process by filter wrapper#377
technoweenie merged 1 commit intogit-lfs:masterfrom
bozaro:more-fast-filter

Conversation

@bozaro
Copy link
Contributor

@bozaro bozaro commented Jun 10, 2015

This change improve git-lfs performance on Windows, becuase Ms Windows function CreateProcess is too expensive (~0.2 sec per call).
This small change reduce my test repository clone time from 4970 sec to 4352 sec (1.14X faster).
See #376 for more details.

@bozaro bozaro force-pushed the more-fast-filter branch from 6275a44 to d412039 Compare June 10, 2015 13:36
This change improve git-lfs performance on Windows
@bozaro bozaro force-pushed the more-fast-filter branch from d412039 to ee0c877 Compare June 10, 2015 13:40
@technoweenie
Copy link
Contributor

Cool thanks! Nice low hanging fruit :)

technoweenie added a commit that referenced this pull request Jun 10, 2015
Remove unnecessary exec the process by filter wrapper
@technoweenie technoweenie merged commit 296dddf into git-lfs:master Jun 10, 2015
@technoweenie technoweenie mentioned this pull request Jun 19, 2015
2 tasks
@technoweenie technoweenie mentioned this pull request Sep 7, 2015
@bozaro bozaro deleted the more-fast-filter branch March 10, 2017 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants