Conversation
The file might be the only copy and recoverable. git-annex does that too.
|
Some comments on questions raised in #290: Is Consistent with Is deleting the corrupt objects the right default? Potential data loss. → No
Not git-lfs' job. Observations (not necessarily blockers for this PR) Nice things we should document somewhere in order to do them in other PRs. I'd say the current user interface is a good default. |
|
LGTM |
|
Awesome, thanks for picking this back up. I'd like to ship this with Git LFS v0.5.2 some time next week. We do need to add a man page for this. |
|
👍 I've put the man page on my todo list for the next days. |
I use |
|
Here's one idea: https://gist.github.com/technoweenie/85e1611dff2289bd7e18 |
|
The gist3 link returns a 404. This one works, though: https://gist.github.com/technoweenie/85e1611dff2289bd7e18 I changed |
|
I added a man page. From my POV this PR is ready. |
Ideally all shell scripts in git-lfs are written for lowest common denominator sh environments. I have no idea what the standard shasum command is, or if there even is one. I agree that it's not worth adding a custom command until we need to though. |
The "git lfs fsck" command accepts a --dry-run option, which was introduced in commit 7cfaa63 of PR git-lfs#373, but which is not documented in our git-lfs-fsck(1) manual page, so we now add an entry for it into the list of options supported by the command.
The "git lfs fsck" command accepts a --dry-run option, which was introduced in commit 7cfaa63 of PR git-lfs#373, but which is not documented in our git-lfs-fsck(1) manual page, so we now add an entry for it into the list of options supported by the command.
The "git lfs fsck" command accepts a --dry-run option, which was introduced in commit 7cfaa63 of PR git-lfs#373, but which is not documented in our git-lfs-fsck(1) manual page, so we now add an entry for it into the list of options supported by the command.
This PR is built on #280 by @zeroshirts and #290 by @technoweenie.
I transferred the test to the new test environment. Should be enough to close #262.
@zeroshirts:
I squashed a05e331 (Add LFS fsck command) and 1c8c54d (code review changes) together and moved
file.Close()right after_, err = io.Copy(oidHash, f).¹ I hope this is ok with you!?¹ See comment in 2f6c3be. If
io.Copyfails, we still want to close the file.