Skip to content

If the batch operation fails, fall back to individual#358

Merged
rubyist merged 5 commits intomasterfrom
fail-batch-gracefully
Jun 15, 2015
Merged

If the batch operation fails, fall back to individual#358
rubyist merged 5 commits intomasterfrom
fail-batch-gracefully

Conversation

@rubyist
Copy link
Contributor

@rubyist rubyist commented Jun 1, 2015

The batch endpoint is still "experimental" and a server may not yet support it. It is off by default in the client, but if gets turned on it should fall back to individual processing if the batch processing throws an error.

@technoweenie
Copy link
Contributor

It'd be cool if a 404/410 response (indicating that the server doesn't even try to implement this) could turn off the lfs.batch config value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this declared inside the function like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's not needed outside the function.

@technoweenie technoweenie mentioned this pull request Jun 11, 2015
38 tasks
rubyist added a commit that referenced this pull request Jun 15, 2015
If the batch operation fails, fall back to individual
@rubyist rubyist merged commit 0e80e80 into master Jun 15, 2015
@rubyist rubyist deleted the fail-batch-gracefully branch June 15, 2015 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants