setup nut for dependency management#331
Conversation
script/test no longer needs script/bootstrap on its own
|
This is ready to go. Changes:
Why nut? Mostly because it worked out of the box. Godep didn't work quite right, and required a hack to get around an issue. We've also had great interactions with Nut's author, @jingweno in past Go projects. He mentioned an intent to support the suggested Go import conventions with a community specified vendor file format. |
|
Looks fine to me. I never had the issue you encountered with godep (didn't have any platform-specific imports) and found it worked fine with updates over time - I see nut update isn't implemented yet - but it's all much the same. Main thing is the rewriting of the imports so it'll build out of the box which is a big plus. |
|
Looks good, a couple notes: Right now nut doesn't have an option to just rewrite imports (owenthereal/nut#8). This means manually typing the full vendored import path, and tools like Updating support would be nice, but working around that is pretty much what we had to do with gpm, so not a big deal (actually seems a little easier, I always had problems with gpm and .git dirs). Running diff --git a/vendor/_nuts/github.com/olekukonko/ts/doc.go b/vendor/_nuts/github.com/olekukonko/ts/doc.go
index d73c57e..50c63ca 100644
--- a/vendor/_nuts/github.com/olekukonko/ts/doc.go
+++ b/vendor/_nuts/github.com/olekukonko/ts/doc.go
@@ -20,7 +20,7 @@ Example
import (
"fmt"
- "github.com/github/git-lfs/vendor/_nuts/github.com/olekukonko/ts"
+ "github.com/olekukonko/ts"
)
func main() {This is code in a commented block, I'm thinking it got rewritten on accident and nut is just putting it back to normal, though I would think that no tool should be rewriting imports in comments. I think it should be safe to put that back as the normal import so we don't have to fix it every time we run nut. |
|
@rubyist: Ah, that might've been rewritten by me originally, and nut is just fixing it. I didn't realize it was in a giant comment block. |
|
I went back and looked at the commits and realized that's probably what happened 👍 |
setup nut for dependency management
|
Thanks for using |
|
@technoweenie How do you fix the |
Trying Nut out. I like the simpler config file. Unfortunately, it doesn't seem to be rewriting the imports for me. owenthereal/nut#24