Conversation
The latest release of Go, 1.11.1 was just published earlier today (on 2 October, 2018). In the spirit of staying up-to-date with the latest version of Go (see [1]), let's make sure that we continue to build correctly, even with the very latest version. [1] moved the tip to Go 1.11, so there shouldn't be anything surprising here. [1]: 074a2d4 (all: use Go 1.11 in CI, 2018-08-28)
PastelMobileSuit
approved these changes
Oct 2, 2018
ttaylorr
added a commit
that referenced
this pull request
Oct 17, 2018
Since the advent of [1], and [2], we use Go 1.11 with modules enabled. This relieves us of the requirement of having Git LFS checked out within the appropriate location beneath the caller's $GOPATH. So, let's remove the guideline, and recommend away from using `go get`, since this command behaves differently based on whether or not its CWD is itself a Go repository. Instead, recommend that we use `git clone`, and do not specify a location to perform the clone in, since Git LFS can be checked out from anywhere. [1]: dfc0f2f (Merge pull request #3298 from git-lfs/ttaylorr/go-1.11.1, 2018-10-08) [2]: 35fe301 (Merge pull request #3208 from git-lfs/ttaylorr/go-mod, 2018-08-29)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest release of Go, 1.11.1 was just published earlier today (on 2
October, 2018).
In the spirit of staying up-to-date with the latest version of Go (see
1), let's make sure that we continue to build correctly, even with the
very latest version.
1 moved the tip to Go 1.11, so there shouldn't be anything surprising
here.
/cc @git-lfs/core