Fix charset http Content-Type header#329
Merged
rubyist merged 1 commit intogit-lfs:masterfrom May 25, 2015
Merged
Conversation
Contributor
|
That dash is definitely a typo on our part, thanks for the fix! If you sign the CLA we can merge it in. |
rubyist
added a commit
that referenced
this pull request
May 25, 2015
Fix charset http Content-Type header
Contributor
Author
|
Nice, thanks. |
Contributor
|
That's good feedback, we should definitely mention it in there. I think the only way one finds out about it is the link in a "failing" build after a PR is submitted. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried implementing an LFS Server in JAVA and came up with this issue. According to https://tools.ietf.org/html/rfc5987, it has to always be "key = value". I also tried this change and my implementation now works (or at least I am one small step further).