Refactored and improved Errorhandling#305
Merged
technoweenie merged 7 commits intogit-lfs:masterfrom May 15, 2015
Merged
Conversation
Contributor
|
Looks good to me. 👍 Thanks for looking though this. When we started this repository over a year ago, we were very new to Go. This command error logging code is probably the oldest code in here :) |
technoweenie
added a commit
that referenced
this pull request
May 15, 2015
Refactored and improved Errorhandling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My changes are mostly refactoring. Non-refactoring changes are:
The cases where
os.MkdirAllandos.Createfail, are (still) handled differently and I'm not sure if this was intended in the first place. (The previous code didn't make it that obvious.) Please review.