tasklog: teach *Logger how to enqueue new *SimpleTask's#2767
Merged
Conversation
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
May 26, 2023
The SimpleTask structure of the "tasklog" package, which was introduced in commit 7a760b6 of PR git-lfs#2756, is used at several points in the implementation of the "git lfs fetch" and "git lfs prune" commands, and in each case is constructed with a call to the NewSimpleTask() function, and then passed to a Logger structure's Enqueue() method. However, in commit 0cad488 of PR git-lfs#2767, a Logger.Simple() method was added to both create a new SimpleTask structure and pass it to a Logger structure's Enqueue() method. This Logger.Simple() method was added to be consistent with other existing similar methods such as Logger.List() and Logger.Percentage(). These other methods are used consistently throughout our code to create and enqueue tasks, so we now update the locations where we call NewSimpleTask() to use the Logger.Simple() method instead. This also provides an opportunity to tidy some of the surrounding code and whitespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a
Simple()method to the*tasklog.LoggerAPI, which is consistent with other existing methods, and was pointed out by @technoweenie in #2757 (comment)./cc @git-lfs/core