Conversation
…into progress-remove-spinner
technoweenie
approved these changes
Dec 5, 2017
Contributor
technoweenie
left a comment
There was a problem hiding this comment.
🤘
Double check my merge commit. I used the built-in GH conflict resolver :)
Contributor
Author
Looks good to me, thanks! 👀. |
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Feb 25, 2025
In PR git-lfs#2757 the output of the "git lfs prune" command was revised to use the methods of the Logger structure of the "tasklog" package to output progress messages, replacing use of the Spinner structure from the older "progress" package. The Spinner structure and its methods were then removed in PR git-lfs#2759, and the "progress" package was removed entirely in PR git-lfs#2762. As part of this change, the "git lfs prune" command's progress messages were reformatted so as to always begin with the Git LFS subcommand name, for example, "prune: 8 local objects, 9 retained, done." Two other Git LFS commands follow the same design, the "git lfs fetch" and "git lfs migrate" commands, but no others. Git commands also do not prefix their progress messages with the name of the subcommand (although messages from a Git remote may be reported with the prefix "remote:"). To help bring all our commands' progress messages into alignment, we simply remove the "prune:" prefix from the messages output by the "git lfs prune" command. We expect to revise the progress messages from the "git lfs fetch" and "git lfs migrate" commands in the same way in subsequent commits of this PR.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Feb 25, 2025
In PR git-lfs#2758 the output of the "git lfs fetch" command was revised to use the methods of the Logger structure of the "tasklog" package to output progress messages, replacing use of the Spinner structure from the older "progress" package. The Spinner structure and its methods were then removed in PR git-lfs#2759, and the "progress" package was removed entirely in PR git-lfs#2762. As part of this change, the "git lfs fetch" command's progress messages were reformatted so as to always begin with the Git LFS subcommand name, for example, "fetch: Fetching reference refs/heads/main". Two other Git LFS commands follow the same design, the "git lfs prune" and "git lfs migrate" commands, but no others. Git commands also do not prefix their progress messages with the name of the subcommand (although messages from a Git remote may be reported with the prefix "remote:"). To help bring all our commands' progress messages into alignment, we simply remove the "fetch:" prefix from the messages output by the "git lfs fetch" command. We have similarly altered the progress messages of the "git lfs prune" command in a previous commit in this PR, and we expect to revise the progress messages from the "git lfs migrate" command in the same way in a subsequent commit in this PR.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Feb 25, 2025
In PR git-lfs#2757 the output of the "git lfs prune" command was revised to use the methods of the Logger structure of the "tasklog" package to output progress messages, replacing use of the Spinner structure from the older "progress" package. The Spinner structure and its methods were then removed in PR git-lfs#2759, and the "progress" package was removed entirely in PR git-lfs#2762. As part of this change, the "git lfs prune" command's progress messages were reformatted so as to always begin with the Git LFS subcommand name, for example, "prune: 8 local objects, 9 retained, done." Two other Git LFS commands follow the same design, the "git lfs fetch" and "git lfs migrate" commands, but no others. Git commands also do not prefix their progress messages with the name of the subcommand (although messages from a Git remote may be reported with the prefix "remote:"). To help bring all our commands' progress messages into alignment, we simply remove the "prune:" prefix from the messages output by the "git lfs prune" command. We expect to revise the progress messages from the "git lfs fetch" and "git lfs migrate" commands in the same way in subsequent commits of this PR.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Feb 25, 2025
In PR git-lfs#2758 the output of the "git lfs fetch" command was revised to use the methods of the Logger structure of the "tasklog" package to output progress messages, replacing use of the Spinner structure from the older "progress" package. The Spinner structure and its methods were then removed in PR git-lfs#2759, and the "progress" package was removed entirely in PR git-lfs#2762. As part of this change, the "git lfs fetch" command's progress messages were reformatted so as to always begin with the Git LFS subcommand name, for example, "fetch: Fetching reference refs/heads/main". Two other Git LFS commands follow the same design, the "git lfs prune" and "git lfs migrate" commands, but no others. Git commands also do not prefix their progress messages with the name of the subcommand (although messages from a Git remote may be reported with the prefix "remote:"). To help bring all our commands' progress messages into alignment, we simply remove the "fetch:" prefix from the messages output by the "git lfs fetch" command. We have similarly altered the progress messages of the "git lfs prune" command in a previous commit in this PR, and we expect to revise the progress messages from the "git lfs migrate" command in the same way in a subsequent commit in this PR.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Feb 25, 2025
In PR git-lfs#2757 the output of the "git lfs prune" command was revised to use the methods of the Logger structure of the "tasklog" package to output progress messages, replacing use of the Spinner structure from the older "progress" package. The Spinner structure and its methods were then removed in PR git-lfs#2759, and the "progress" package was removed entirely in PR git-lfs#2762. As part of this change, the "git lfs prune" command's progress messages were reformatted so as to always begin with the Git LFS subcommand name, for example, "prune: 8 local objects, 9 retained, done." Two other Git LFS commands follow the same design, the "git lfs fetch" and "git lfs migrate" commands, but no others. Git commands also do not prefix their progress messages with the name of the subcommand (although messages from a Git remote may be reported with the prefix "remote:"). To help bring all our commands' progress messages into alignment, we simply remove the "prune:" prefix from the messages output by the "git lfs prune" command. We expect to revise the progress messages from the "git lfs fetch" and "git lfs migrate" commands in the same way in subsequent commits of this PR.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Feb 25, 2025
In PR git-lfs#2758 the output of the "git lfs fetch" command was revised to use the methods of the Logger structure of the "tasklog" package to output progress messages, replacing use of the Spinner structure from the older "progress" package. The Spinner structure and its methods were then removed in PR git-lfs#2759, and the "progress" package was removed entirely in PR git-lfs#2762. As part of this change, the "git lfs fetch" command's progress messages were reformatted so as to always begin with the Git LFS subcommand name, for example, "fetch: Fetching reference refs/heads/main". Two other Git LFS commands follow the same design, the "git lfs prune" and "git lfs migrate" commands, but no others. Git commands also do not prefix their progress messages with the name of the subcommand (although messages from a Git remote may be reported with the prefix "remote:"). To help bring all our commands' progress messages into alignment, we simply remove the "fetch:" prefix from the messages output by the "git lfs fetch" command. We have similarly altered the progress messages of the "git lfs prune" command in a previous commit in this PR, and we expect to revise the progress messages from the "git lfs migrate" command in the same way in a subsequent commit in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes
spinner.gofrom packageprogresssince it is no longer used within Git LFS (see: #2757, #2758).Looking at usage of the exported identifiers in
meter.gois the only remaining thing to look at in the progress package before it can be removed entirely 🎉 ./cc @git-lfs/core