Change Adapter Begin() signature to accept an AdapterConfig interface#1774
Merged
technoweenie merged 2 commits intotq-masterfrom Dec 15, 2016
Merged
Change Adapter Begin() signature to accept an AdapterConfig interface#1774technoweenie merged 2 commits intotq-masterfrom
technoweenie merged 2 commits intotq-masterfrom
Conversation
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Jul 21, 2021
We update the comment describing the Begin method of the Adapter interface to match that for the corresponding method of the SSH transfer adapter, which was added in commit 594f8e3 of PR git-lfs#4446. The older comment for the interface description has been out of sync with the actual method signature since at least commit 303156e of PR git-lfs#1774, when the maxConcurrency integer argument was replaced with the current "cfg" AdapterConfig one.
pcal43
pushed a commit
to pcal43/git-lfs-hack
that referenced
this pull request
Jul 22, 2021
We update the comment describing the Begin method of the Adapter interface to match that for the corresponding method of the SSH transfer adapter, which was added in commit 594f8e3 of PR git-lfs#4446. The older comment for the interface description has been out of sync with the actual method signature since at least commit 303156e of PR git-lfs#1774, when the maxConcurrency integer argument was replaced with the current "cfg" AdapterConfig one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements my suggested change of the adapter
Begin()interface, to accept a configuration object interface, instead of amaxConcurrency intargument. This gives us flexibility to add more properties if needed without breaking the public interface. If we decided to add something likeMaxSchmeckles() int, adapters would keep working without ever having to deal with schmeckles if they don't need to.The PR is currently based on #1772, which is about to merge. Once merged, the base will change to
tq-master.