Conversation
ttaylorr
added a commit
that referenced
this pull request
Dec 2, 2016
technoweenie
added a commit
that referenced
this pull request
Dec 5, 2016
Backport #1727 for v1.5.x: Fix Install in root problems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1717 by splitting
localstorage.ResolveDirs()so thatinstallanduninstallcan do what they need iflfs.InRepo()is true. This is meant to be a bug fix, and definitely doesn't try to fix any package design issues. I want to backport this PR to v1.5.3, and explore a redesign of this code for 2.x.