Merged
Conversation
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Sep 8, 2023
In commit 4c422b4 of PR git-lfs#113 the script/release script was added, which runs the script/release.go program, which uploaded release binaries to GitHub via a POST request, based on the values in a bin/releases/build_matrix.json file. This file is no longer created because the script/build.go file and accompanying script/bootstrap script were removed in commit 2235198 of PR git-lfs#3144. As we do not use the script/release or script/release.go files anymore as part of our release process, we can delete them now.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Sep 8, 2023
In commit 4c422b4 of PR git-lfs#113 the script/release script was added, which runs the script/release.go program to upload release binaries to GitHub via a POST request based on the values in a bin/releases/build_matrix.json file. This file is no longer created because the script/build.go file and accompanying script/bootstrap script were removed in commit 2235198 of PR git-lfs#3144. As we do not use the script/release or script/release.go files anymore as part of our release process, we can delete them now.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Sep 8, 2023
In commit 4c422b4 of PR git-lfs#113 the script/release script was added, which builds and runs a Go program from the script/script.go and script/release.go files. The mainRelease() function in that program uploads release binaries to GitHub via a POST request based on the values in a bin/releases/build_matrix.json file. However, that JSON file is no longer created because the script/build.go file and accompanying script/bootstrap script were removed in commit 2235198 of PR git-lfs#3144. As we do not use the script/release or remaining script/*.go files anymore as part of our release process, we can delete them now.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Sep 8, 2023
In commit 4c422b4 of PR git-lfs#113 the script/release script was added, which builds and runs a Go program from the script/script.go and script/release.go files. The mainRelease() function in that program uploads release binaries to GitHub via a POST request based on the values in a bin/releases/build_matrix.json file. However, that JSON file is no longer created because the script/build.go file and accompanying script/bootstrap script were removed in commit 2235198 of PR git-lfs#3144. As we do not use the script/release or remaining script/*.go files anymore as part of our release process, we can delete them now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add's a release script that uploads the compiled binaries to the Releases API with the proper labels and everything.