Remove unused scripts and update README and file permissions#57
Merged
chrisd8088 merged 3 commits intogit-lfs:mainfrom Sep 11, 2023
Merged
Remove unused scripts and update README and file permissions#57chrisd8088 merged 3 commits intogit-lfs:mainfrom
chrisd8088 merged 3 commits intogit-lfs:mainfrom
Conversation
In the initial development of this project, several scripts were introduced to tag and publish Docker images for Git LFS to the Docker Hub. However, we have not published any for at least five years, according to the site: https://hub.docker.com/r/gitlfs/build-dockers https://hub.docker.com/r/gitlfs/build-dockers/tags Other images were also pushed to the Quay.io registry circa 2015: https://quay.io/repository/andyneff/git-lfs_dockers We can therefore remove these scripts now, along with some other unused files.
Much of the initial text of the README file no longer applies, as we do not publish Docker images to the Docker Hub or any other registry. Therefore can we simplify the README considerably, and update the remaining portions that are still relevant to reflect our current practices, project locations, and terminology.
Our Dockerfiles do not need to be executed as scripts, so we can set their file permissions accordingly.
bk2204
approved these changes
Sep 11, 2023
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Sep 13, 2023
The last substantive update to the docs/linux-build.md file was made in PR git-lfs#480 in 2015, and the information in the file is no longer accurate or relevant. While the `rpm/build_rpms.bsh` script mentioned in the text still exists, we typically run that script only within Docker containers, and we have updated our Docker build documentation both in prior commits in this PR and in PR git-lfs/build-dockers#57. Therefore we simply remove the old docs/linux-build.md file in favour of our revised documentation, which describes how to build and use Docker images to generate both Debian and RPM packages of Git LFS.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Sep 13, 2023
The last substantive update to the docs/linux-build.md file was made in PR git-lfs#480 in 2015, and the information in the file is no longer accurate or relevant. While the `rpm/build_rpms.bsh` script mentioned in the text still exists, we typically run that script only within Docker containers, and we have updated our Docker build documentation both in prior commits in this PR and in PR git-lfs/build-dockers#57. Therefore we simply remove the old docs/linux-build.md file in favour of our revised documentation, which describes how to build and use Docker images to generate both Debian and RPM packages of Git LFS.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Sep 13, 2023
The last substantive update to the docs/linux-build.md file was made in PR git-lfs#480 in 2015, and the information in the file is no longer accurate or relevant. While the `rpm/build_rpms.bsh` script mentioned in the text still exists, we typically run that script only within Docker containers, and we have updated our Docker build documentation both in prior commits in this PR and in PR git-lfs/build-dockers#57. Therefore we simply remove the old docs/linux-build.md file in favour of our revised documentation, which describes how to build and use Docker images to generate both Debian and RPM packages of Git LFS.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Sep 13, 2023
The last substantive update to the docs/linux-build.md file was made in PR git-lfs#480 in 2015, and the information in the file is no longer accurate or relevant. While the `rpm/build_rpms.bsh` script mentioned in the text still exists, we typically run that script only within Docker containers, and we have updated our Docker build documentation both in prior commits in this PR and in PR git-lfs/build-dockers#57. Therefore we simply remove the old docs/linux-build.md file in favour of our revised documentation, which describes how to build and use Docker images to generate both Debian and RPM packages of Git LFS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the initial development of this project, several scripts were introduced to tag and publish Docker images for Git LFS to the Docker Hub. However, we have not published any for at least five years, according to the site. Other images were also pushed to the Quay.io registry circa 2015. We can therefore remove these scripts now, along with some other unused files.
Much of the initial text of the
READMEfile no longer applies, so can we simplify theREADMEconsiderably, and update the remaining portions that are still relevant to reflect our current practices, project locations, and terminology.As well, our Dockerfiles do not need to be executed as scripts, so we can set their file permissions accordingly.
The changes in this PR have been validated by running a version of our CI and release workflows from the Git LFS project against this PR's branch and confirming they still succeed, and also by building several of the Docker images manually.