Merged
Conversation
Bump the version to 1.17 and update the URL to refer to the new download location, since the old one doesn't work anymore.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Dec 27, 2022
Since the original introduction of the rpm/build_rpms.bsh script in commit 4a71627 of PR git-lfs#332 it has checked for the absence of the "go" binary and, if it is not found, installs the golang package, except on CentOS 5 where fetches and patches a golang.spec file and then builds a local RPM using that in order to install Go. However, in commit b560b85 of PR git-lfs#1298 and in commit git-lfs/build-dockers@64a3a9f of PR git-lfs/build-dockers#3 we dropped support for CentOS 5. And in commit 88430de of PR git-lfs#654 we updated our CentOS Dockerfiles (before they were moved to the git-lfs/build-dockers repository) to download and install Go from the googleapis.com service, and we still continue to do this but as of commit git-lfs/build-dockers@c638503 in PR git-lfs/build-dockers#35 we now use the golang.org service. This direct download obviates the logic in our rpm/build_rpms.bsh script to install the golang package, and the special handling for CentOS 5 is also obsolete, so we remove this logic from our script.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Dec 27, 2022
Since the original introduction of the rpm/build_rpms.bsh script in commit 4a71627 of PR git-lfs#332 it has checked for the absence of the "go" binary and, if it is not found, installs the golang package, except on CentOS 5 where fetches and patches a golang.spec file and then builds a local RPM using that in order to install Go. However, in commit b560b85 of PR git-lfs#1298 and in commit git-lfs/build-dockers@64a3a9f of PR git-lfs/build-dockers#3 we dropped support for CentOS 5. And in commit 88430de of PR git-lfs#654 we updated our CentOS Dockerfiles (before they were moved to the git-lfs/build-dockers repository) to download and install Go from the googleapis.com service, and we still continue to do this but as of commit git-lfs/build-dockers@c638503 in PR git-lfs/build-dockers#35 we now use the golang.org service. This direct download obviates the logic in our rpm/build_rpms.bsh script to install the golang package, and the special handling for CentOS 5 is also obsolete, so we remove this logic from our script.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Dec 28, 2022
Since the original introduction of the rpm/build_rpms.bsh script in commit 4a71627 of PR git-lfs#332 it has checked for the absence of the "go" binary and, if it is not found, installs the golang package, except on CentOS 5 where fetches and patches a golang.spec file and then builds a local RPM using that in order to install Go. However, in commit b560b85 of PR git-lfs#1298 and in commit git-lfs/build-dockers@64a3a9f of PR git-lfs/build-dockers#3 we dropped support for CentOS 5. And in commit 88430de of PR git-lfs#654 we updated our CentOS Dockerfiles (before they were moved to the git-lfs/build-dockers repository) to download and install Go from the googleapis.com service, and we still continue to do this but as of commit git-lfs/build-dockers@c638503 in PR git-lfs/build-dockers#35 we now use the golang.org service. This direct download obviates the logic in our rpm/build_rpms.bsh script to install the golang package, and the special handling for CentOS 5 is also obsolete, so we remove this logic from our script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Go version to 1.17 and fix the links, since the old link format no longer works. Then, add a Dockerfile for Debian 11.