centos: don't build Git LFS during setup#30
Merged
bk2204 merged 1 commit intogit-lfs:masterfrom Nov 26, 2019
Merged
Conversation
We build with the Docker containers primarily on Actions these days, where the containers are created new each time. Building Git LFS during the setup stage means that we must run the entire build and testsuite for a container which will only be used once, which is very expensive. Remove the code which builds during the setup stage of the Docker containers to make the process faster.
chrisd8088
added a commit
to chrisd8088/build-dockers
that referenced
this pull request
Dec 26, 2022
In commit 330be9d of PR git-lfs#30 we removed the directives from the CentOS Dockerfiles which compiled a version of Git LFS using a stable release version during the container image setup/build stage, as was originally done to save compilation time later when the containers were run. This was no longer valuable as it increased the overall runtime in GitHub Actions, where we build containers but only use them once, so we removed the directives. However, we did not remove the supporting references to the DOCKER_LFS_BUILD_VERSION environment variable which could be used to set the specific version of the "bootstrapped" Git LFS build, so we remove them now along with the relevant documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We build with the Docker containers primarily on Actions these days, where the containers are created new each time. Building Git LFS during the setup stage means that we must run the entire build and testsuite for a container which will only be used once, which is very expensive.
Remove the code which builds during the setup stage of the Docker containers to make the process faster.