Fix double .exe suffixes in CMakeLists.txt #2966
Merged
dscho merged 1 commit intogit-for-windows:mainfrom Jan 5, 2021
dennisameling:fix-double-exe
Merged
Fix double .exe suffixes in CMakeLists.txt #2966dscho merged 1 commit intogit-for-windows:mainfrom dennisameling:fix-double-exe
dscho merged 1 commit intogit-for-windows:mainfrom
dennisameling:fix-double-exe
Conversation
1 task
By mistake, the `.exe` extension is appended _twice_ when installing the dashed executables into `libexec/git-core/` on Windows (the extension is already appended when adding items to the `git_links` list in the `#Creating hardlinks` section). Signed-off-by: Dennis Ameling <dennis@dennisameling.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
|
Thank you! I reworded the commit message to make it more likely that the patch will be accepted upstream (but I want to wait with that until we are sure that there are no further problems lurking there). |
dscho
added a commit
that referenced
this pull request
Jan 6, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 7, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 9, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 14, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 14, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 14, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 14, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 14, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 15, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 18, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 18, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 18, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 20, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 20, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 27, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 28, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 29, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Jan 29, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 1, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 2, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 2, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 2, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 2, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 4, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 4, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 4, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 4, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 4, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 4, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 5, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 5, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 7, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 7, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 7, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 8, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 9, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
to dscho/git
that referenced
this pull request
Feb 9, 2021
…-exe Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 9, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 10, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 10, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 10, 2021
Fix double .exe suffixes in CMakeLists.txt
dscho
added a commit
that referenced
this pull request
Feb 10, 2021
Fix double .exe suffixes in CMakeLists.txt
git-for-windows-ci
pushed a commit
that referenced
this pull request
Feb 10, 2021
Fix double .exe suffixes in CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2965
If you want to verify this yourself, please follow the steps from #2915 (comment)