Skip to content

parse-options.c: make OPTION__COUNTUP consider negative values #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pranitbauva1997 wants to merge 1 commit into from
Closed

parse-options.c: make OPTION__COUNTUP consider negative values #212

pranitbauva1997 wants to merge 1 commit into from

Conversation

@pranitbauva1997
Copy link
Contributor

@pranitbauva1997 pranitbauva1997 commented Mar 16, 2016

The reason to make it consider negative values or more specifically
"unspecified" values is to differentiate between the option passed
once, multiple times or with --no-option. This makes the receiver
know what actually happened with the arguments which is particularly
required with option have multiple levels of that option.

Eg. :
initialize verbose = -1
git commit => verbose = -1
git commit -v => verbose = 1
git commit -v -v => verbose = 1
git commit --no-verbose => verbose = 0

Signed-off-by: Pranit Bauva pranit.bauva@gmail.com

The discussion on the mailing list[1] suggested this approach.
I plan to include this with my previous patch regarding "configuration
for commonly used command git commit -v" as this is a requirement for
latter.

[1] : http://thread.gmane.org/gmane.comp.version-control.git/289027

@submitgit
Copy link
Member

submitgit commented Mar 16, 2016

@pranitbauva1997 sent this commit (d9c691a...102abb1) as a patch to the mailing list with submitGit - here on Gmane, MARC

@pranitbauva1997
parse-options.c: make OPTION__COUNTUP consider negative values
2f7422d 
The reason to make it consider negative values or more specifically
"unspecified" values is to give the ability to differentiate between
once, multiple time or with --no-option.

Eg. :
initialize verbose = -1
`git commit` => verbose = -1
`git commit -v` => verbose = 1
`git commit -v -v` => verbose = 2
`git commit --no-verbose` => verbose = 0

Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>

---
The discussion about this patch:
[1] : http://thread.gmane.org/gmane.comp.version-control.git/289027

Previous version of the patch:
[v1] : http://thread.gmane.org/gmane.comp.version-control.git/289061

Changes introduced:
Use a different language in commit message to make the change and its
utility more clear.
@pranitbauva1997 pranitbauva1997 deleted the multi-verbosity branch May 2, 2016 12:03
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Dec 11, 2019
@kewillford
Merge pull request git#212 fsmonitor updates for improved performance
be5e0bb 
fsmonitor updates for improved performance
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jan 17, 2020
@kewillford @derrickstolee
Merge pull request git#212 fsmonitor updates for improved performance
2cb02ea 
fsmonitor updates for improved performance
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 24, 2020
@kewillford @derrickstolee
Merge pull request git#212 fsmonitor updates for improved performance
c51cf80 
fsmonitor updates for improved performance
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 2, 2020
@dscho @derrickstolee
Merge updates to serialized status
99a88a2 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 3, 2020
@dscho @derrickstolee
Merge updates to serialized status
0d6f16c 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 3, 2020
@dscho @derrickstolee
Merge updates to serialized status
ae0c595 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Dec 23, 2020
@dscho
Merge updates to serialized status
673284d 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit to derrickstolee/git that referenced this pull request Dec 24, 2020
@dscho
Merge updates to serialized status
a88c497 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Dec 29, 2020
@dscho
Merge updates to serialized status
910b645 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 19, 2021
@dscho @jeffhostetler
Merge updates to serialized status
df35772 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 10, 2021
@dscho @derrickstolee
Merge updates to serialized status
78747da 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 15, 2021
@dscho @derrickstolee
Merge updates to serialized status
417d67e 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 17, 2021
@dscho @derrickstolee
Merge updates to serialized status
1b8ce67 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 2, 2021
@dscho @derrickstolee
Merge updates to serialized status
70415c8 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 10, 2021
@dscho @derrickstolee
Merge updates to serialized status
70f9ea8 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 16, 2021
@dscho @derrickstolee
Merge updates to serialized status
c6f9f43 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jan 18, 2022
@dscho @derrickstolee
Merge updates to serialized status
51c9e51 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jan 28, 2022
@dscho @ldennington
Merge updates to serialized status
0a13891 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 16, 2022
@dscho
Merge updates to serialized status
4ce1ba4 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request May 22, 2022
@dscho @vdye
Merge updates to serialized status
437290e 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 23, 2022
@dscho
Merge updates to serialized status
bfb2203 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 27, 2022
@dscho
Merge updates to serialized status
0f4f4e2 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jul 14, 2022
@dscho
Merge updates to serialized status
8465077 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Sep 30, 2022
@dscho @derrickstolee
Merge updates to serialized status
cbbb1b3 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Oct 4, 2022
@dscho
Merge updates to serialized status
f155bca 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 8, 2022
@dscho
Merge updates to serialized status
8b395e3 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 15, 2023
@dscho
Merge updates to serialized status
9240c0f 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 15, 2023
@dscho @derrickstolee
Merge updates to serialized status
d8f17a1 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request May 11, 2023
@dscho @derrickstolee
Merge updates to serialized status
94846ca 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 23, 2023
@dscho
Merge updates to serialized status
d5908c1 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@dscho
Merge updates to serialized status
01ec887 
Includes these pull requests:

	#1
	git#6
	git#10
	git#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@dscho @vdye
Merge updates to serialized status
b750ad7 
Includes these pull requests:

	#1
	git#6
	git#10
	git#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@kewillford @derrickstolee
Merge pull request git#212 fsmonitor updates for improved performance
3e81032 
fsmonitor updates for improved performance
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@dscho @derrickstolee
Merge updates to serialized status
89daca9 
Includes these pull requests:

	#1
	git#6
	git#10
	git#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@dscho @vdye
Merge updates to serialized status
1caf76f 
Includes these pull requests:

	#1
	git#6
	git#10
	git#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@dscho @derrickstolee
Merge updates to serialized status
649085a 
Includes these pull requests:

	#1
	git#6
	git#10
	git#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Apr 30, 2024
@dscho
Merge updates to serialized status
0feb1ef 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request May 31, 2024
@dscho
Merge updates to serialized status
130ec0d 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 19, 2024
@dscho
Merge updates to serialized status
36958c7 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jul 19, 2024
@dscho
Merge updates to serialized status
0c158e3 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 23, 2024
@dscho @mjcheetham
Merge updates to serialized status
ea134a8 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Sep 30, 2024
@dscho
Merge updates to serialized status
bdc5e99 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Oct 9, 2024
@dscho
Merge updates to serialized status
9b44aaa 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit to derrickstolee/git that referenced this pull request Dec 10, 2024
@dscho @mjcheetham
Merge updates to serialized status
aca1a51 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 5, 2025
@dscho
Merge updates to serialized status
2a231d8 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Sep 2, 2025
@dscho
Merge updates to serialized status
b428276 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Nov 7, 2025
@dscho
Merge updates to serialized status
ed74b80 
Includes these pull requests:

	#1
	#6
	#10
	#11
	git#157
	git#212
	git#260
	git#270

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pranitbauva1997 @submitgit