Add support for writing a mach-o file with an LC_BUILD_VERSION command#524
Merged
philipc merged 1 commit intogimli-rs:masterfrom Mar 27, 2023
Merged
Add support for writing a mach-o file with an LC_BUILD_VERSION command#524philipc merged 1 commit intogimli-rs:masterfrom
LC_BUILD_VERSION command#524philipc merged 1 commit intogimli-rs:masterfrom
Conversation
philipc
approved these changes
Mar 26, 2023
Contributor
philipc
left a comment
There was a problem hiding this comment.
Thanks! This looks ok for the API since it's necessarily specific to Mach-O.
|
|
||
| impl MachOBuildVersion { | ||
| fn cmdsize(&self) -> u32 { | ||
| // Same size for both endianness, and we don't have `ntools`. |
Contributor
There was a problem hiding this comment.
I don't think endianness ever changes sizes. Maybe you meant both address sizes?
Contributor
Author
There was a problem hiding this comment.
It doesn't, I was just being clear why we didn't need anything passed in from the caller (and just picked an arbitrary Endianess).
Contributor
|
It doesn't need to be done for this PR, but would you be able to add some Mach-O test files to https://github.com/gimli-rs/object-testfiles? Ideally both x86_64 and arm64, but whatever you have access to is fine. |
|
Hello folks, do we need to release a new version for this project? |
Contributor
|
Yes, I'm planning to do a new release soon. |
Contributor
|
Released 0.31.0 |
mcbegamerxx954
pushed a commit
to mcbegamerxx954/object
that referenced
this pull request
Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to fix rust-lang/rust#106021.
Unsure if this API is right, though.