flatpak: remove references to systemd unit#7676
Merged
mitchellh merged 1 commit intoghostty-org:mainfrom Jun 24, 2025
Merged
Conversation
Flatpak currently does not export systemd user units. As such, remove references to it from D-Bus services to prevent D-Bus daemon from trying to start a non-existent service. Additionally, make sure that the D-Bus service name is correct for debug builds.
8fd7741 to
32e61d2
Compare
Contributor
Author
|
Note that after #7433, this fix is required for Flatpak builds to run when launched from launcher. |
mitchellh
approved these changes
Jun 24, 2025
Contributor
mitchellh
left a comment
There was a problem hiding this comment.
Appreciate the follow up. Thanks.
jcollie
added a commit
to jcollie/ghostty
that referenced
this pull request
Jun 25, 2025
Replaces ghostty-org#7676 When building as a flatpak, don't install the systemd user services since flatpaks can't use them. Remove references to the systemd service from the DBus service. Also, customize the app metadata depending on the debug mode. Co-authored-by: Leorize <leorize+oss@disroot.org>
jcollie
added a commit
to jcollie/ghostty
that referenced
this pull request
Jun 26, 2025
Replaces ghostty-org#7676 When building as a flatpak, don't install the systemd user services since flatpaks can't use them. Remove references to the systemd service from the DBus service. Also, customize the app metadata depending on the debug mode. Co-authored-by: Leorize <leorize+oss@disroot.org>
mitchellh
pushed a commit
to jcollie/ghostty
that referenced
this pull request
Jun 26, 2025
Replaces ghostty-org#7676 When building as a flatpak, don't install the systemd user services since flatpaks can't use them. Remove references to the systemd service from the DBus service. Also, customize the app metadata depending on the debug mode. Co-authored-by: Leorize <leorize+oss@disroot.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flatpak currently does not export systemd user units. As such, remove references to it from D-Bus services to prevent D-Bus daemon from trying to start a non-existent service.
Additionally, make sure that the D-Bus service name is correct for debug builds.
Follow up to #7433