Do sample_to_timestamp calculation with 64 bit precision to avoid overflow#388
Merged
ggerganov merged 2 commits intoggml-org:masterfrom Jan 8, 2023
Merged
Conversation
ggerganov
reviewed
Jan 8, 2023
Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
anandijain
pushed a commit
to anandijain/whisper.cpp
that referenced
this pull request
Apr 28, 2023
…o avoid overflow (ggml-org#388) * Do calculation with 64 bit precision to avoid overflow * Update whisper.cpp Co-authored-by: Georgi Gerganov <ggerganov@gmail.com> Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
…o avoid overflow (ggml-org#388) * Do calculation with 64 bit precision to avoid overflow * Update whisper.cpp Co-authored-by: Georgi Gerganov <ggerganov@gmail.com> Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As written, the
sample_to_timestampfunction will overflow around 22 and a half minutes and it will start returning negative timestamps.22m23s = 1343s
1343s * 16000 samples/s = 21488000 samples
Passing 21488000 to
sample_to_timestampwould result in 100*21488000 (2148800000), which overflows to -2146167296 before that result is divided again by the sample rate.By doing the multiplication with 64 bit precision, you avoid the overflow and you can now process audio clips longer than 22 minutes.