Merged
Conversation
df98547 to
8793585
Compare
Member
Yes - good point. I have to update |
ggerganov
added a commit
that referenced
this pull request
Jan 5, 2023
ggerganov
approved these changes
Jan 5, 2023
Member
ggerganov
left a comment
There was a problem hiding this comment.
Tested all platforms - everything is good!
Ready to merge if you are good?
Contributor
Author
|
Yes, I don't have any changes left to push. Thanks for reviewing and testing the patch set. |
anandijain
pushed a commit
to anandijain/whisper.cpp
that referenced
this pull request
Apr 28, 2023
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could not eliminate the separate index argument in the f16 load and store macros, so this patch set needs testing on other architectures.
The existing GGML_F32x4_REDUCE macro performs as well as the implementation in #366 so I used the existing one.
When I test with the F32 model, ggml_vec_dot_f16 and ggml_vec_mad_f16 are still being called. Is that expected?