Add runtime destination install#345
Merged
ggerganov merged 1 commit intoggml-org:masterfrom Dec 31, 2022
Merged
Conversation
needed for mingw32 build to successfully install the dlls in the correct location
anandijain
pushed a commit
to anandijain/whisper.cpp
that referenced
this pull request
Apr 28, 2023
needed for mingw32 build to successfully install the dlls in the correct location
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
needed for mingw32 build to successfully install the dlls in the correct location
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for mingw32 build to successfully install the dlls in the correct location.
I realise the default setting in the CMakefile disables the shared library build for mingw32, but when I force it on, I need this change to install the dlls.
(As an aside, we compile and ship binaries for about 9 different platforms for this library for the Julia ecosystem. JuliaPackaging/Yggdrasil#6021)