Fix UTF-8 handling (including colors)#79
Merged
ggerganov merged 1 commit intoggml-org:masterfrom Mar 13, 2023
Merged
Conversation
beiller
approved these changes
Mar 13, 2023
Contributor
There was a problem hiding this comment.
In my opinion, for what that's worth, this is the cleanest and simplest fix for the UTF-8 issue.
Thank you @j-f1 for the initial idea of this approach #73
We have 3 PRs for this same issue FYI @ggerganov
Correction 4 PRs :)
ggerganov
approved these changes
Mar 13, 2023
Member
ggerganov
left a comment
There was a problem hiding this comment.
Thank you for this!
It would've taken me so much time to figure this out. Great teamwork 🦙
|
Looks like on Windows it's still can't understand non-english input prompts with some non-latin symbols... Even after change of CMD locale codepage to UTF-8 with command 'chcp 65001' |
3 tasks
SamuelOliveirads
pushed a commit
to SamuelOliveirads/llama.cpp
that referenced
this pull request
Dec 29, 2025
* Do not quantize activations if not necessary * Do not quantize activations if not necessary also for MoE models --------- Co-authored-by: Iwan Kawrakow <iwan.kawrakow@gmail.com>
SamuelOliveirads
pushed a commit
to SamuelOliveirads/llama.cpp
that referenced
this pull request
Dec 29, 2025
* Revert "Do not quantize activations if not necessary (ggml-org#79)" This reverts commit 0bf4d99. * Fixed compilation after revert --------- Co-authored-by: Iwan Kawrakow <iwan.kawrakow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11 (including color handling). Largely based on #73 (props to @j-f1), but doesn't pull any additional dependencies.
Sample output from 13B model with default parameters: