Merged
Conversation
Member
|
Excellent! Why is it "Draft"? |
Contributor
Author
|
Woops, sorry, ready for review now |
ggerganov
approved these changes
Mar 13, 2023
ggerganov
added a commit
that referenced
this pull request
Mar 13, 2023
blackhole89
pushed a commit
that referenced
this pull request
Mar 15, 2023
SamuelOliveirads
pushed a commit
to SamuelOliveirads/llama.cpp
that referenced
this pull request
Dec 29, 2025
When I changed iqk_mul_mat to use type-1 dot products for type-0 legacy quants, I forgot to also change the vec_dot_type when the dot product is done via ggml as in flash attention. This commit fixes it. Co-authored-by: Iwan Kawrakow <iwan.kawrakow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the draft to support llama.cpp being built by CMake. Most of the things were copied from whisper.cpp's CMake so it should be pretty identical.
This currently builds on my M1 Air with the same perf as using the makefile, but it currently doesn't builds on windows because of #74. Doing the revert of said commit makes it compile on Windows as well.This currently works both on my M1 Air and on my Windows 10 machine.