Skip to content

main.cpp fixes, refactoring#571

Merged
anzz1 merged 4 commits intomasterfrom
patch-main-fix-refactor-1
Mar 28, 2023
Merged

main.cpp fixes, refactoring#571
anzz1 merged 4 commits intomasterfrom
patch-main-fix-refactor-1

Conversation

@anzz1
Copy link
Contributor

@anzz1 anzz1 commented Mar 28, 2023

moved fixes and refactorings from #555

  • main: entering empty line passes back control without new input in interactive/instruct modes
  • instruct mode: keep prompt fix
  • instruct mode: duplicate instruct prompt fix
  • refactor: move common console code from main->common

- main: entering empty line passes back control without new input in interactive/instruct modes
- instruct mode: keep prompt fix
- instruct mode: duplicate instruct prompt fix
- refactor: move common console code from main->common
@anzz1 anzz1 requested a review from slaren March 28, 2023 13:04
@anzz1 anzz1 requested a review from slaren March 28, 2023 13:54
Copy link
Member

@slaren slaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anzz1 anzz1 merged commit 7b8dbcb into master Mar 28, 2023
@anzz1 anzz1 deleted the patch-main-fix-refactor-1 branch March 28, 2023 14:10
@anzz1 anzz1 mentioned this pull request Mar 28, 2023
@mitesh741 mitesh741 mentioned this pull request Dec 6, 2023
AAbushady pushed a commit to AAbushady/llama.cpp that referenced this pull request Jan 27, 2024
SamuelOliveirads pushed a commit to SamuelOliveirads/llama.cpp that referenced this pull request Dec 29, 2025
* Move Vulkan stuff inside if (GGML_VULKAN)

* Minor

---------

Co-authored-by: Iwan Kawrakow <iwan.kawrakow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants