Merged
Conversation
maekawatoshiki
commented
Mar 12, 2023
main.cpp
Outdated
| fin.close(); | ||
| } | ||
|
|
||
| free(f_buf); |
Contributor
Author
There was a problem hiding this comment.
f_buf will not be free if this function returns earlier, but I think it does not matter since it's a small amount of memory :)
ggerganov
requested changes
Mar 12, 2023
Contributor
Author
|
Thank you for your review. Fixed as you mentioned. |
ggerganov
approved these changes
Mar 13, 2023
rooprob
pushed a commit
to rooprob/llama.cpp
that referenced
this pull request
Aug 2, 2023
Speed up rmsnorm by using sqrtf/expf
Alcpz
pushed a commit
to Alcpz/llama.cpp
that referenced
this pull request
Dec 4, 2025
1. Fixed audio-detokenizer.cpp:708 - Changed std::expf(log_abs) to
expf(log_abs)
- The expf function is in the global namespace, not in the std namespace
2. Fixed mtmd-cli.cpp:332 - Changed eval_message(ctx, msgs) to
eval_message(ctx, msgs.back())
- The eval_message function expects a single message reference, not a
vector
- We pass the last message in the vector (the user prompt)
*Make sure to read the [contributing
guidelines](https://github.com/ggml-org/llama.cpp/blob/master/CONTRIBUTING.md)
before submitting a PR*
SamuelOliveirads
pushed a commit
to SamuelOliveirads/llama.cpp
that referenced
this pull request
Dec 29, 2025
Co-authored-by: Iwan Kawrakow <iwan.kawrakow@gmail.com>
wine99
pushed a commit
to wine99/llama.cpp
that referenced
this pull request
Feb 27, 2026
…er_rebase hardcoded name handling for rope_freqs.weight
rururush
pushed a commit
to USTC-ADSL/llama.cpp
that referenced
this pull request
Mar 16, 2026
* wip * refactor: rewrite dequantize_row_q4_0 by intrinsic * log for debug * fix q4 intrinsic * small opt * wip * wip * add vtcm_quota_size * add perf log for hexagon-npu backend * wip * add log * sync after a specfic op * increase worker thread priority * fix unbalanced thread slice * small slict to fit in vtcm cache * limit the supported row element size * opt 4_0 dequant * fix q4 dequant * add power_utils * add rms_norm * wip * enable rms_norm f32 * fix rms_norm with param * fix compiling flags * use float * fix small row size * vectorized rms norm * wip * read 2 vectors * rename * add perf log on update * set empty tensors handle also * merge some rpc functions * opt param update * wip * print more log * add struct for update param config * add npu_device_graph_set_tensor_with_param * merge tensor and params update * wip * wip * make as template to reuse * vectorize dequantize_row_q8_0 * opt * avoid using union to store q data * wip * wip * wip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I noticed that the model loader is not using buffered IO, so I added a piece of code for buffering.
I measured the loading time only for llama 7B on my M1 Pro Macbook, but it reduced the time from 1316ms to 749ms.