llama.cpp : add documentation about rope_freq_base and scale values#3401
Merged
llama.cpp : add documentation about rope_freq_base and scale values#3401
Conversation
Member
Author
|
I noticed that this is an issue in Downstream users should be careful to update the default values. |
ggerganov
approved these changes
Sep 29, 2023
Member
ggerganov
left a comment
There was a problem hiding this comment.
Maybe also add a hot topics entry given the impact and importance of this change
This was referenced Sep 29, 2023
joelkuiper
added a commit
to vortext/llama.cpp
that referenced
this pull request
Oct 2, 2023
…example * 'master' of github.com:ggerganov/llama.cpp: ggml-cuda : perform cublas mat mul of quantized types as f16 (ggml-org#3412) llama.cpp : add documentation about rope_freq_base and scale values (ggml-org#3401) train : fix KQ_pos allocation (ggml-org#3392) llama : quantize up to 31% faster on Linux and Windows with mmap (ggml-org#3206) readme : update hot topics + model links (ggml-org#3399) readme : add link to grammars app (ggml-org#3388) swift : fix build on xcode 15 (ggml-org#3387) build : enable more non-default compiler warnings (ggml-org#3200) ggml_tensor: update the structure comments. (ggml-org#3283) ggml : release the requested thread pool resource (ggml-org#3292) llama.cpp : split llama_context_params into model and context params (ggml-org#3301) ci : multithreaded builds (ggml-org#3311) train : finetune LORA (ggml-org#2632) gguf : basic type checking in gguf_get_* (ggml-org#3346) gguf : make token scores and types optional (ggml-org#3347) ci : disable freeBSD builds due to lack of VMs (ggml-org#3381) llama : custom attention mask + parallel decoding + no context swaps (ggml-org#3228) docs : mark code as Bash (ggml-org#3375) readme : add Mistral AI release 0.1 (ggml-org#3362) ggml-cuda : perform cublas fp16 matrix multiplication as fp16 (ggml-org#3370)
jhen0409
added a commit
to mybigday/llama.rn
that referenced
this pull request
Oct 3, 2023
…cent breaking change ref: ggml-org/llama.cpp#3401
yusiwen
pushed a commit
to yusiwen/llama.cpp
that referenced
this pull request
Oct 7, 2023
…gml-org#3401) * llama.cpp : add documentation about rope_freq_base and scale values * add notice to hot topics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, setting
rope_freq_baseto10000andrope_freq_scaleto1inllama_context_paramswould cause llama.cpp to use model's default value. Now, to use the model default values, these parameters must be set to zero.Setting
rope_freq_baseto10000will cause problems with models trained on a different value, such as CodeLlama-7B. Therefore, downstream users should be careful to update the default values of these parameters.When using
llama_context_default_params()to initializellama_context_paramswithout changing these parameters, no further action is required.llama_context_default_params()will correctly set the value of these parameters to zero.