Skip to content

ui: fix mobile chat form overflow and bust stale bundle cache#24158

Merged
allozaur merged 1 commit into
ggml-org:masterfrom
ServeurpersoCom:ui/fix-mobile-height
Jun 9, 2026
Merged

ui: fix mobile chat form overflow and bust stale bundle cache#24158
allozaur merged 1 commit into
ggml-org:masterfrom
ServeurpersoCom:ui/fix-mobile-height

Conversation

@ServeurpersoCom

Copy link
Copy Markdown
Contributor

Overview

This PR fixes a mobile nitpick and a developer pain point in one go

Additional information

Chat form overflowing below the visual viewport on mobile browsers: the root container moves from h-screen to h-dvh so the layout tracks the actual visible height, with identical behavior in standalone PWA and on desktop.

Stale bundle cache busting: the build plugin appends the Vite hash as a query string to bundle.js and bundle.css in index.html, so a simple reload always fetches the latest build. Essential when iterating on UI fixes and verifying them on a real device.

Before

Bug

After

BugFix

Requirements

On mobile browsers the root container uses h-screen (100vh), which measures
the large viewport with the browser UI retracted. With the Chrome toolbar
visible the chat form sinks below the visual viewport by exactly the toolbar
height. Switch to h-dvh so the layout always tracks the visible height. In
standalone PWA and on desktop dvh equals vh, so nothing changes there.

Checking such CSS details on a real phone is painful: bundle.js and
bundle.css keep fixed names, so a normal reload serves stale cached bundles.
The build plugin now appends the Vite hash as a query string (bundle.js?<hash>),
so every new build is fetched fresh after a simple reload.
@ServeurpersoCom

Copy link
Copy Markdown
Contributor Author

cc @allozaur Can you test it with your llama.app packaging and your smartphone? This should not change anything for you while repairing Android.

@ServeurpersoCom ServeurpersoCom requested a review from allozaur June 5, 2026 05:48
@kashif

kashif commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

works nicely on ios too

Image from iOS

@ServeurpersoCom

Copy link
Copy Markdown
Contributor Author

Thanks for the iPhone test!

@allozaur

allozaur commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Just a side note that we will have mobile UI improvements implemented in nearest future, but let's merge the fix to address this particular issue.

@allozaur allozaur requested a review from ggerganov June 5, 2026 12:47
@allozaur allozaur merged commit efbacf8 into ggml-org:master Jun 9, 2026
6 checks passed
Jcfunk added a commit to Jcfunk/llama.cpp that referenced this pull request Jun 11, 2026
* upstream/HEAD: (329 commits)
  vendor : update LibreSSL to 4.3.2 (ggml-org#24397)
  Remove padding and multiple D2D copies for MTP (ggml-org#24086)
  chat: fix LFM2/LFM2.5 ignoring json_schema (ggml-org#24377)
  CUDA: Fix ssm_scan_f32 data-races (ggml-org#24360)
  ci : bump komac version (ggml-org#24396)
  speculative : fix "ngram-map-k4v" name in logging (ggml-org#24253)
  webui: implement pinned conversations support (ggml-org#21387)
  graph: Fix granite speech model inference by applying embedding scale when deepstack is not used (ggml-org#24357)
  ci : fix windows release (ggml-org#24369)
  ui: add opt-in run_javascript frontend tool (ggml-org#24244)
  mtmd: build_vit batching (ggml-org#24352)
  vulkan: reduce iq1 shared memory usage for mul_mm (ggml-org#24287)
  vulkan: add `v_dot2_f32_f16` support in matrix-matrix multiplication and Flash Attention (ggml-org#24123)
  ui: Fix excessive style recalculation on hover (ggml-org#24243)
  mtmd: refactor video subproc handling (ggml-org#24316)
  server: log prompts to directory (ggml-org#22031)
  ui: fix mobile chat form overflow and bust stale bundle cache (ggml-org#24158)
  ggml : add GGML_OP_COL2IM_1D (ggml-org#24206)
  server : do not clear slots without unified KV cache (ggml-org#24190)
  models : fix plamo2 attention_key/value_length regression (ggml-org#24317)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants