cmake: fix KleidiAI install target failure with EXCLUDE_FROM_ALL#19581
Merged
danbev merged 2 commits intoggml-org:masterfrom Feb 15, 2026
Merged
cmake: fix KleidiAI install target failure with EXCLUDE_FROM_ALL#19581danbev merged 2 commits intoggml-org:masterfrom
danbev merged 2 commits intoggml-org:masterfrom
Conversation
Fix for the bug ggml-org#19501 by adding EXCLUDE_FROM_ALL to FetchContent_Declare. This properly excludes KleidiAI from both build and install targets, preventing install failures when GGML_CPU_KLEIDIAI=ON is used. The KleidiAI source files are still compiled into libggml-cpu.so, preserving all functionality.
danbev
approved these changes
Feb 13, 2026
danbev
reviewed
Feb 13, 2026
|
Hi, just chiming in as the original reporter to confirm that this fixes the install target for me! |
Contributor
Author
|
Looks like CI/CD has some issues and is causing some tests to fail that are not related to this PR. |
Member
|
This failure is related though. :) |
liparetejas
pushed a commit
to liparetejas/llama.cpp
that referenced
this pull request
Feb 23, 2026
…ml-org#19581) * cmake: fix KleidiAI install target failure with EXCLUDE_FROM_ALL Fix for the bug ggml-org#19501 by adding EXCLUDE_FROM_ALL to FetchContent_Declare. This properly excludes KleidiAI from both build and install targets, preventing install failures when GGML_CPU_KLEIDIAI=ON is used. The KleidiAI source files are still compiled into libggml-cpu.so, preserving all functionality. * addressed code review comments
bartowski1182
pushed a commit
to bartowski1182/llama.cpp
that referenced
this pull request
Mar 2, 2026
…ml-org#19581) * cmake: fix KleidiAI install target failure with EXCLUDE_FROM_ALL Fix for the bug ggml-org#19501 by adding EXCLUDE_FROM_ALL to FetchContent_Declare. This properly excludes KleidiAI from both build and install targets, preventing install failures when GGML_CPU_KLEIDIAI=ON is used. The KleidiAI source files are still compiled into libggml-cpu.so, preserving all functionality. * addressed code review comments
ArberSephirotheca
pushed a commit
to ArberSephirotheca/llama.cpp
that referenced
this pull request
Mar 3, 2026
…ml-org#19581) * cmake: fix KleidiAI install target failure with EXCLUDE_FROM_ALL Fix for the bug ggml-org#19501 by adding EXCLUDE_FROM_ALL to FetchContent_Declare. This properly excludes KleidiAI from both build and install targets, preventing install failures when GGML_CPU_KLEIDIAI=ON is used. The KleidiAI source files are still compiled into libggml-cpu.so, preserving all functionality. * addressed code review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the bug #19501 by adding
EXCLUDE_FROM_ALLto theFetchContent_Declarecall for KleidiAI. This properly excludes the KleidiAI library from both theallandinstalltargets, preventing CMake install failures when building withGGML_CPU_KLEIDIAI=ON. The KleidiAI source files are still compiled directly intolibggml-cpu.so, so functionality is preserved.