Skip to content

metal : consolidate unary ops#19490

Merged
ggerganov merged 1 commit intomasterfrom
gg/metal-unary-opt
Feb 11, 2026
Merged

metal : consolidate unary ops#19490
ggerganov merged 1 commit intomasterfrom
gg/metal-unary-opt

Conversation

@ggerganov
Copy link
Member

cont #19390

  • Common implementation of the unary kernels
  • Extend support for non-cont src0

@github-actions github-actions bot added testing Everything test related ggml changes relating to the ggml tensor library for machine learning Apple Metal https://en.wikipedia.org/wiki/Metal_(API) labels Feb 10, 2026
@ggerganov ggerganov merged commit ceaa89b into master Feb 11, 2026
76 of 78 checks passed
@ggerganov ggerganov deleted the gg/metal-unary-opt branch February 11, 2026 05:51
@CISC
Copy link
Member

CISC commented Feb 11, 2026

This seems to have broken ELU:

2026-02-11T06:40:21.0104340Z 36: Failing tests:
2026-02-11T06:40:21.0104420Z 36:   ELU(type=f32,ne_a=[128,2,2,2],v=0)
2026-02-11T06:40:21.0104480Z 36:   ELU(type=f32,ne_a=[5,7,11,13],v=0)
2026-02-11T06:40:21.0104540Z 36:   ELU(type=f32,ne_a=[128,2,2,2],v=1)
2026-02-11T06:40:21.0104600Z 36:   ELU(type=f32,ne_a=[5,7,11,13],v=1)
2026-02-11T06:40:21.0104880Z 36:   Backend MTL0: �[1;31mFAIL�[0m

@ggerganov
Copy link
Member Author

Should be fixed in #19511

liparetejas pushed a commit to liparetejas/llama.cpp that referenced this pull request Feb 23, 2026
bartowski1182 pushed a commit to bartowski1182/llama.cpp that referenced this pull request Mar 2, 2026
ArberSephirotheca pushed a commit to ArberSephirotheca/llama.cpp that referenced this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Apple Metal https://en.wikipedia.org/wiki/Metal_(API) ggml changes relating to the ggml tensor library for machine learning testing Everything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants